[FIX]core_faculty: fixed name field (openeducat#345)

Author: dipakvarma

openeducat_core/demo/faculty_demo.xml

@@ -3,7 +3,8 @@
     <data noupdate="1">
         <record id="op_faculty_1" model="op.faculty">
             <field name="title" ref="base.res_partner_title_mister"/>
-            <field name="name">James</field>
+            <field name="name">James D church</field>
+            <field name="first_name">James</field>
             <field name="middle_name">D</field>
             <field name="last_name">Church</field>
             <field name="gender">male</field>
@@ -22,7 +23,8 @@
 
         <record id="op_faculty_2" model="op.faculty">
             <field name="title" ref="base.res_partner_title_mister"/>
-            <field name="name">Dylan</field>
+            <field name="name">Dylan Q Hidalgo</field>
+            <field name="first_name">Dylan</field>
             <field name="middle_name">Q</field>
             <field name="last_name">Hidalgo</field>
             <field name="gender">male</field>
@@ -41,7 +43,8 @@
 
         <record id="op_faculty_3" model="op.faculty">
             <field name="title" ref="base.res_partner_title_miss"/>
-            <field name="name">Lucia</field>
+            <field name="name">Lucia K Sison</field>
+            <field name="first_name">Lucia</field>
             <field name="middle_name">K</field>
             <field name="last_name">Sison</field>
             <field name="gender">female</field>
@@ -60,7 +63,8 @@
 
         <record id="op_faculty_4" model="op.faculty">
             <field name="title" ref="base.res_partner_title_mister"/>
-            <field name="name">Badru</field>
+            <field name="name">Badru V Turay</field>
+            <field name="first_name">Badru</field>
             <field name="middle_name">V</field>
             <field name="last_name">Turay</field>
             <field name="gender">male</field>
@@ -79,7 +83,8 @@
 
         <record id="op_faculty_5" model="op.faculty">
             <field name="title" ref="base.res_partner_title_miss"/>
-            <field name="name">Maaike</field>
+            <field name="name">Maaike L Effiong</field>
+            <field name="first_name">Maaike</field>
             <field name="middle_name">L</field>
             <field name="last_name">Effiong</field>
             <field name="gender">female</field>
@@ -98,7 +103,8 @@
 
         <record id="op_faculty_6" model="op.faculty">
             <field name="title" ref="base.res_partner_title_mister"/>
-            <field name="name">Harpreet Singh</field>
+            <field name="name">Harpreet Singh K Bagga</field>
+            <field name="first_name">Harpreet Singh</field>
             <field name="middle_name">K</field>
             <field name="last_name">Bagga</field>
             <field name="gender">male</field>
@@ -117,7 +123,8 @@
 
         <record id="op_faculty_7" model="op.faculty">
             <field name="title" ref="base.res_partner_title_miss"/>
-            <field name="name">Sanjana</field>
+            <field name="name">Sanjana E Pillay</field>
+            <field name="first_name">Sanjana</field>
             <field name="middle_name">E</field>
             <field name="last_name">Pillay</field>
             <field name="gender">female</field>
@@ -136,7 +143,8 @@
 
         <record id="op_faculty_8" model="op.faculty">
             <field name="title" ref="base.res_partner_title_miss"/>
-            <field name="name">Tanya</field>
+            <field name="name">Tanya M Wagle</field>
+            <field name="first_name">Tanya</field>
             <field name="middle_name">M</field>
             <field name="last_name">Wagle</field>
             <field name="gender">female</field>
@@ -155,7 +163,8 @@
 
         <record id="op_faculty_9" model="op.faculty">
             <field name="title" ref="base.res_partner_title_mister"/>
-            <field name="name">Chang</field>
+            <field name="name">Chang D Suen</field>
+            <field name="first_name">Chang</field>
             <field name="middle_name">D</field>
             <field name="last_name">Suen</field>
             <field name="gender">male</field>
@@ -174,7 +183,8 @@
 
         <record id="op_faculty_10" model="op.faculty">
             <field name="title" ref="base.res_partner_title_miss"/>
-            <field name="name">Komal</field>
+            <field name="name">Komal H Shah</field>
+            <field name="first_name">Komal</field>
             <field name="middle_name">H</field>
             <field name="last_name">Shah</field>
             <field name="gender">female</field>

openeducat_core/models/faculty.py

@@ -30,6 +30,8 @@ class OpFaculty(models.Model):
     _inherits = {"res.partner": "partner_id"}
     partner_id = fields.Many2one('res.partner', 'Partner',
                                  required=True, ondelete="cascade")
+    first_name = fields.Char('First Name', size=128, required=True,
+                             translate=True)
     middle_name = fields.Char('Middle Name', size=128)
     last_name = fields.Char('Last Name', size=128, required=True)
     birth_date = fields.Date('Birth Date', required=True)
@@ -67,11 +69,20 @@ def _check_birthdate(self):
                 raise ValidationError(_(
                     "Birth Date can't be greater than current date!"))
 
+    @api.onchange('first_name', 'middle_name', 'last_name')
+    def _onchange_name(self):
+        if not self.middle_name:
+            self.name = str(self.first_name) + \
+                        " " + str(self.last_name)
+        else:
+            self.name = str(self.first_name) + \
+                        " " + str(self.middle_name) + \
+                        " " + str(self.last_name)
+
     def create_employee(self):
         for record in self:
             vals = {
-                'name': record.name + ' ' + (record.middle_name or '') +
-                        ' ' + record.last_name,
+                'name': record.name,
                 'country_id': record.nationality.id,
                 'gender': record.gender,
                 'address_home_id': record.partner_id.id
@@ -86,3 +97,4 @@ def get_import_templates(self):
             'label': _('Import Template for Faculties'),
             'template': '/openeducat_core/static/xls/op_faculty.xls'
         }]
+