xenopsd: make vncterm less errorprone

Previous match had a wildcard which made it easy to miss added cases, change it
so all the guest types have to be enumerated.

Signed-off-by: Pau Ruiz Safont <[email protected]>

Author: psafont

ocaml/xenopsd/xc/xenops_server_xen.ml

@@ -2313,11 +2313,12 @@ module VM = struct
         )
         (create_device_model_config vm vmextra vbds vifs vgpus vusbs) ;
       match vm.Vm.ty with
-      | Vm.PV {vncterm= true; vncterm_ip= ip; _}
-      | Vm.PVH {vncterm= true; vncterm_ip= ip; _}
-      | Vm.PVinPVH {vncterm= true; vncterm_ip= ip; _} ->
-          Service.PV_Vnc.start ~xs ?ip di.Xenctrl.domid
-      | _ ->
+      | PV {vncterm; vncterm_ip= ip; _}
+      | PVH {vncterm; vncterm_ip= ip; _}
+      | PVinPVH {vncterm; vncterm_ip= ip; _} ->
+          if vncterm then
+            Service.PV_Vnc.start ~xs ?ip di.Xenctrl.domid
+      | HVM _ ->
           ()
     with Device.Ioemu_failed (name, msg) ->
       raise (Xenopsd_error (Failed_to_start_emulator (vm.Vm.id, name, msg)))