Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Respect CMAKE_EXE_LINKER_FLAGS/CMAKE_SHARED_LINKER_FLAGS flags set via CLI #830

Draft
pramodk wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Respect CMAKE_EXE_LINKER_FLAGS/CMAKE_SHARED_LINKER_FLAGS flags set via CLI #830

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbed7dc
Respect CMAKE_EXE_LINKER_FLAGS/CMAKE_SHARED_LINKER_FLAGS flags set vi…
pramodk Jun 22, 2022
6f9c31e
Add linker flags after coreneuron library (clang and -Wl,--as-needed …
pramodk Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Respect CMAKE_EXE_LINKER_FLAGS/CMAKE_SHARED_LINKER_FLAGS flags set vi… 
…a CLI

In case of Clang, we were always overriding the above mentioned flags
and hence cmake args were ignored (resuliting in link errors)
  • Loading branch information
@pramodk
pramodk committed Jun 22, 2022
commit bbed7dcbeee876de74941b8b123b3c2cf28d0874
4 changes: 2 additions & 2 deletions CMake/config/CompilerFlagsHelpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ foreach(COMPILER_LANGUAGE ${SUPPORTED_COMPILER_LANGUAGE_LIST})
# Force same ld behavior as when called from gcc --as-needed forces the linker to check whether
# a dynamic library mentioned in the command line is actually needed by the objects being
# linked. Symbols needed in shared objects are already linked when building that library.
set(CMAKE_EXE_LINKER_FLAGS "-Wl,--as-needed")
set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--as-needed")
set(CMAKE_EXE_LINKER_FLAGS "-Wl,--as-needed ${CMAKE_EXE_LINKER_FLAGS}")
Copy link
Contributor

@olupton olupton Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use https://cmake.org/cmake/help/latest/command/string.html#append to avoid repeating the variable name, I think, but no big deal.

set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--as-needed ${CMAKE_SHARED_LINKER_FLAGS}")

# rest of the world
else()
Expand Down