issue#370: slab re-balance is not thread-safty in function do_item_get

zwChan · dormando · commit ecea7458d7cb · 2014-12-27T19:07:49.000-08:00
diff --git a/items.c b/items.c
@@ -581,7 +581,7 @@ item *do_item_get(const char *key, const size_t nkey, const uint32_t hv) {
          * of item_lock, cache_lock, slabs_lock. */
         if (slab_rebalance_signal &&
             ((void *)it >= slab_rebal.slab_start && (void *)it < slab_rebal.slab_end)) {
-            do_item_unlink_nolock(it, hv);
+            do_item_unlink(it, hv);
             do_item_remove(it);
             it = NULL;
         }

Original file line number	Diff line number	Diff line change
`@@ -581,7 +581,7 @@ item do_item_get(const char key, const size_t nkey, const uint32_t hv) {`
`581`	`581`	`* of item_lock, cache_lock, slabs_lock. */`
`582`	`582`	`if (slab_rebalance_signal &&`
`583`	`583`	`((void )it >= slab_rebal.slab_start && (void )it < slab_rebal.slab_end)) {`
`584`		`- do_item_unlink_nolock(it, hv);`
	`584`	`+ do_item_unlink(it, hv);`
`585`	`585`	`do_item_remove(it);`
`586`	`586`	`it = NULL;`
`587`	`587`	`}`