Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: HoneyryderChuck/httpx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: HoneyryderChuck/httpx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: gh-138
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on May 3, 2026

  1. wip

    @HoneyryderChuck
    HoneyryderChuck committed May 3, 2026
    Configuration menu
    Copy the full SHA
    935a147 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2026

  1. fix: prevent removal of wrong selectable when previous closed 

    a connection, when closed, triggers the `on_close` callback, which will
eventually deregister the io from the selectables list in the selector.
However, when this callback is triggered as a result of
`Connection#interests`, which is invoked while the selectables list is
being traversed via `Array#delete_if`, it was causing, due to the block
yielding true, the next element in the list to be wrongly deleted.

This is a bug in the implementation of `Array#delete_if`, reported here:
https://bugs.ruby-lang.org/issues/22021 . in the meantime, the
workaround is to verify again, whenever the io is identified as closed,
whether the object is still part of the selectables list.

Fixes #138
    @HoneyryderChuck
    HoneyryderChuck committed May 4, 2026
    Configuration menu
    Copy the full SHA
    1177ee3 View commit details
    Browse the repository at this point in the history
Loading