Only use Elixir SDK for mix format if it has an Erlang SDK

Fixes #3001

Author: KronicDeth

CHANGELOG.md

@@ -558,6 +558,8 @@
     If a variable is declared in an EEx tag then it is actually missing its declaration and cannot be resolved, so ignore its usage.
 * [#3043](https://github.com/KronicDeth/intellij-elixir/pull/3043) - [@KronicDeth](https://github.com/KronicDeth)
   * Check if module is disposed when write action is run for `syncLibraries`.
+* [#3044](https://github.com/KronicDeth/intellij-elixir/pull/3044) - [@KronicDeth](https://github.com/KronicDeth)
+  * Only use Elixir SDK for `mix format` if it has an Erlang SDK.
 
 ## v14.0.0
 

resources/META-INF/changelog.html

@@ -16,6 +16,7 @@ <h1>v14.0.1</h1>
         If a variable is declared in an EEx tag then it is actually missing its declaration and cannot be resolved, so ignore its usage.
       </li>
       <li>Check if module is disposed when write action is run for <code>syncLibraries</code>.</li>
+      <li>Only use Elixir SDK for <code>mix format</code> if it has an Erlang SDK.</li>
     </ul>
   </li>
 </ul>

src/org/elixir_lang/Elixir.kt

@@ -31,9 +31,13 @@ object Elixir {
     }
 
     fun elixirSdkToEnsuredErlangSdk(elixirSdk: Sdk): Sdk =
-        elixirSdk.sdkAdditionalData?.let { it as SdkAdditionalData }?.ensureErlangSdk()
+        elixirSdkToErlangSdk(elixirSdk)
             ?: throw MissingErlangSdk(elixirSdk)
 
+    fun elixirSdkHasErlangSdk(elixirSdk: Sdk): Boolean = elixirSdkToErlangSdk(elixirSdk) != null
+    fun elixirSdkToErlangSdk(elixirSdk: Sdk): Sdk? =
+        elixirSdk.sdkAdditionalData?.let { it as SdkAdditionalData }?.erlangSdk
+
     /**
      * Adds `-pa ebinDirectory` for those in the `elixirSdk` that aren't in the `erlangSdk`
      */

src/org/elixir_lang/formatter/MixFormatExternalFormatProcessor.kt

@@ -12,6 +12,7 @@ import com.intellij.openapi.roots.ProjectRootManager
 import com.intellij.openapi.util.TextRange
 import com.intellij.psi.PsiFile
 import com.intellij.psi.codeStyle.ExternalFormatProcessor
+import org.elixir_lang.Elixir.elixirSdkHasErlangSdk
 import org.elixir_lang.Mix
 import org.elixir_lang.code_style.CodeStyleSettings
 import org.elixir_lang.psi.ElixirFile
@@ -42,7 +43,7 @@ class MixFormatExternalFormatProcessor : ExternalFormatProcessor {
 
                 application.executeOnPooledThread {
                     workingDirectory(source)?.let { workingDirectory ->
-                        mostSpecificSdk(source)?.let { sdk ->
+                        mostSpecificSdk(source)?.takeIf(::elixirSdkHasErlangSdk)?.let { sdk ->
                             format(workingDirectory, sdk, document.text)?.let { formattedText ->
                                 application.invokeLater {
                                     if (source.isValid) {
@@ -94,7 +95,7 @@ class MixFormatExternalFormatProcessor : ExternalFormatProcessor {
                 commandLine
             } catch (fileNotFoundException: FileNotFoundException) {
                 LOGGER.info(fileNotFoundException)
-                
+
                 null
             }
 

src/org/elixir_lang/sdk/erlang_dependent/SdkAdditionalData.java

@@ -88,15 +88,4 @@ public Sdk getErlangSdk() {
     public void setErlangSdk(@Nullable Sdk erlangSdk) {
         this.erlangSdk = erlangSdk;
     }
-
-    @NotNull
-    public Sdk ensureErlangSdk() throws MissingErlangSdk {
-        Sdk erlangSdk = getErlangSdk();
-
-        if (erlangSdk == null) {
-            throw new MissingErlangSdk(elixirSdk);
-        }
-
-        return erlangSdk;
-    }
 }