Skip to content

Commit 1af8eca

Browse files
[CHANGE] Implements code review changes - AIL-44
1 parent 9eb2674 commit 1af8eca

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ jobs:
3434
with:
3535
python-version: '3.9'
3636

37-
- name: Install Mypy Dependencies
38-
run: pip install mypy
37+
- name: Install Test Dependencies
38+
run: pip install .[test]
3939

4040
- name: Type Checking with Mypy
4141
run: mypy

learnosity_sdk/request/init.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ def __init__(
4040
self.security = security.copy()
4141
self.secret = secret
4242
self.request = request
43-
if request is not None and hasattr(request, 'copy'):
43+
# TODO: Fix improper handling when request is a string
44+
if isinstance(request, dict):
4445
self.request = request.copy()
4546
self.action = action
4647

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
'pytest-subtests',
2626
'responses >=0.8.1',
2727
'types-requests',
28+
'types-Jinja2',
2829
'mypy',
2930
]
3031

tests/unit/test_uuid.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from typing import cast
21
import unittest
32
import re
43
from learnosity_sdk.utils import Uuid
@@ -13,6 +12,5 @@ def test_generate(self) -> None:
1312
prog = re.compile('[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}')
1413
result = prog.match(generated)
1514

16-
assert result != None
17-
result = cast(re.Match[str], result)
15+
assert result is not None
1816
assert result.group() == generated

0 commit comments

Comments
 (0)