Skip to content

Commit 2012163

Browse files
[CHANGE] Implements code review changes - AIL-44
1 parent a3938d1 commit 2012163

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,13 @@ jobs:
1313
uses: actions/checkout@v4
1414

1515
- name: Set up Python
16-
uses: actions/setup-python@v4
17-
with:
18-
python-version: '3.9'
16+
uses: actions/setup-python@v5
1917

20-
- name: Install Mypy Dependencies
21-
run: pip install mypy
18+
- name: Install Test Dependencies
19+
run: pip install .[test]
2220

2321
- name: Type Checking with Mypy
24-
run: mypy --strict --install-types --non-interactive learnosity_sdk
22+
run: mypy learnosity_sdk
2523

2624
tests:
2725
runs-on: ubuntu-latest

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[tool.mypy]
2+
strict = true

setup.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,12 @@
1919
]
2020

2121
TEST_REQUIRES = [
22+
'mypy',
2223
'pytest >=4.6.6',
2324
'pytest-cov >=2.8.1',
2425
'pytest-subtests',
2526
'responses >=0.8.1',
27+
'types-requests'
2628
]
2729

2830
# Extract the markdown content of the README to be sent to Pypi as the project description page.

0 commit comments

Comments
 (0)