Skip to content

Commit 611382c

Browse files
fixup! [FEATURE] Add telemetry to request meta by default
- Fix version-checking in make dist-check-version - Update README deploy steps to remove reference to editing version
1 parent b53f296 commit 611382c

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ dist: distclean
4747
$(PYTHON) setup.py sdist; \
4848
$(PYTHON) setup.py bdist_wheel --universal
4949
dist-upload: dist-check-version clean test dist-upload-twine
50-
dist-check-version: PKG_VER=v$(shell sed -n "s/^.*VERSION\s\+=\s\+'\([^']\+\)'.*$$/\1/p" setup.py)
50+
dist-check-version: PKG_VER=v$(shell sed -n "s/^.*__version__\s\+=\s\+'\([^']\+\)'.*$$/\1/p" learnosity_sdk/_version.py)
5151
dist-check-version: GIT_TAG=$(shell git describe --tags)
5252
dist-check-version:
5353
ifeq ('$(shell echo $(GIT_TAG) | grep -qw "$(PKG_VER)")', '')
54-
$(error Version number $(PKG_VER) in setup.py does not match git tag $(GIT_TAG))
54+
$(error Version number $(PKG_VER) in learnosity_sdk/_version.py does not match git tag $(GIT_TAG))
5555
endif
5656
dist-upload-twine: pip-requirements-dev dist # This target doesn't do any safety check!
5757
$(call venv-activate); \

README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -246,11 +246,10 @@ Alternatively, if you only care about the version you're currently running, you
246246

247247
# Deploying to PyPi
248248

249-
1. Update the version number in `learnosity_sdk/_version.py`
250-
2. Install the dev requirements `pip install -r requirements-dev.txt`
251-
3. Run `python setup.py sdist` to create the source distribution
252-
4. Run `python setup.py bdist_wheel --universal` to create the binary distribution
253-
5. Run `twine upload dist/*` to deploy the distributions to PyPi
249+
1. Install the dev requirements `pip install -r requirements-dev.txt`
250+
2. Run `python setup.py sdist` to create the source distribution
251+
3. Run `python setup.py bdist_wheel --universal` to create the binary distribution
252+
4. Run `twine upload dist/*` to deploy the distributions to PyPi
254253

255254
You will need to be set up as a maintainer in order to do this.
256255

0 commit comments

Comments
 (0)