Skip to content

Commit a998640

Browse files
authored
Merge pull request #32 from linuxonrails/port_08_colorpicker_from_ts_to_js_#17
Fix: remove propTypes warning #17
2 parents 03b85e8 + 0cfdd57 commit a998640

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

08 Colorpicker/readme.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ Let's start by defining only one slider to control the red component of a given
9595
onChange={event =>
9696
props.onColorUpdated(
9797
{
98-
red: event.target.value,
98+
red: parseInt(event.target.value, 10),
9999
green: props.color.green,
100100
blue: props.color.blue,
101101
}
@@ -174,7 +174,7 @@ Let's start by defining only one slider to control the red component of a given
174174
onChange={event =>
175175
props.onColorUpdated(
176176
{
177-
red: event.target.value,
177+
red: parseInt(event.target.value, 10),
178178
green: props.color.green,
179179
blue: props.color.blue,
180180
}
@@ -192,7 +192,7 @@ Let's start by defining only one slider to control the red component of a given
192192
props.onColorUpdated(
193193
{
194194
red: props.color.red,
195-
green: event.target.value,
195+
green: parseInt(event.target.value, 10),
196196
blue: props.color.blue,
197197
}
198198
)
@@ -210,7 +210,7 @@ Let's start by defining only one slider to control the red component of a given
210210
{
211211
red: props.color.red,
212212
green: props.color.green,
213-
blue: event.target.value,
213+
blue: parseInt(event.target.value, 10),
214214
}
215215
)
216216
}

08 Colorpicker/src/colorpicker.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export const ColorPicker = props => (
1010
onChange={event =>
1111
props.onColorUpdated(
1212
{
13-
red: event.target.value,
13+
red: parseInt(event.target.value, 10),
1414
green: props.color.green,
1515
blue: props.color.blue,
1616
}
@@ -28,7 +28,7 @@ export const ColorPicker = props => (
2828
props.onColorUpdated(
2929
{
3030
red: props.color.red,
31-
green: event.target.value,
31+
green: parseInt(event.target.value, 10),
3232
blue: props.color.blue,
3333
}
3434
)
@@ -46,7 +46,7 @@ export const ColorPicker = props => (
4646
{
4747
red: props.color.red,
4848
green: props.color.green,
49-
blue: event.target.value,
49+
blue: parseInt(event.target.value, 10),
5050
}
5151
)
5252
}

0 commit comments

Comments
 (0)