Bikeshed defaults, update release notes, cleanup whitespace

Author: adlai

doc/release-notes-0.1.0.md

@@ -22,10 +22,10 @@ Notable changes
 Throttling to avoid IRC flood
 ------------------------------------
 
-See [366](https://github.com/joinmarket-org/joinmarket/issues/366). Introduced a 1 line/second limit and a secondary 3kB/10s limit to data 
+See [366](https://github.com/joinmarket-org/joinmarket/issues/366). Introduced a 1 line/second limit and a secondary 3kB/10s limit to data
 sending. It is hoped that this will reduce or remove the possibility of bots getting
 kicked from the server when engaging in large transactions. PING messages bypass
-the limits, and responses to orderbook requests must wait for other messages (i.e. 
+the limits, and responses to orderbook requests must wait for other messages (i.e.
 have lowest priority.) In case of very large transactions, takers should bump their
 maker_timeout_sec variable in the config file from the new default of 60s to something
 higher.
@@ -36,15 +36,15 @@ Dynamic fee calculation
 See [346](https://github.com/joinmarket-org/joinmarket/issues/346). Before these changes, the default fee was set statically at 10,000 satoshis, but this
 is clearly insufficient on the Bitcoin network as of now, unless the transaction is
 very small (and Joinmarket transactions are perforce larger than normal). An emergency
-fix of 30,000 satoshis was applied to the master branch, but in this update the 
+fix of 30,000 satoshis was applied to the master branch, but in this update the
 transaction fee is determined from the output of estimatefee, if running Core, or from
 the API at blockcypher.com if running from blockr. Due to the joinmarket protocol, we
 cannot know in advance the exact size of the transaction when we create it. Hence,
 some reasonable heuristics are applied to estimate the size of the transaction, then
 use the value returned from estimatefee, combined with a user-configured choice of
 how many blocks to target combination for, to get to a reasonable transaction fee.
-The user can reset the value of `tx_fees` in the joinmarket.cfg file from the default 
-value of 3 (i.e. targetting confirmation within 3 blocks) to make confirmation likely 
+The user can reset the value of `tx_fees` in the joinmarket.cfg file from the default
+value of 3 (i.e. targetting confirmation within 3 blocks) to make confirmation likely
 to be faster or slower.
 
 Users should be aware that in case of sweep transactions or large N transactions - whereever
@@ -62,25 +62,25 @@ heavily tested to that end.
 Code refactoring
 -----------------------------------
 
-See [340](https://github.com/joinmarket-org/joinmarket/issues/340) and 
-[345](https://github.com/joinmarket-org/joinmarket/issues/345). 
+See [340](https://github.com/joinmarket-org/joinmarket/issues/340) and
+[345](https://github.com/joinmarket-org/joinmarket/issues/345).
 This is considered an initial (but quite significant) step in cleaning
 up the codebase, making formatting standardised, and enabling better analysis of the code.
-The set of commits created preserves blame in git, and the diff can be verified using 
-the yapf tool, combined with diff. See [340](https://github.com/joinmarket-org/joinmarket/issues/340) 
+The set of commits created preserves blame in git, and the diff can be verified using
+the yapf tool, combined with diff. See [340](https://github.com/joinmarket-org/joinmarket/issues/340)
 for details. A manual review of these changes
 was undertaken also. There were no functional changes to the code as a result of this.
 
 New yield-generator scripts.
 -----------------------------------
 
-See [353](https://github.com/joinmarket-org/joinmarket/issues/353), 
+See [353](https://github.com/joinmarket-org/joinmarket/issues/353),
 [357](https://github.com/joinmarket-org/joinmarket/issues/357),
-[371](https://github.com/joinmarket-org/joinmarket/issues/371). 
+[371](https://github.com/joinmarket-org/joinmarket/issues/371).
 The updates are spread over a few PRs due to refactoring
-and bugfix changes. 
+and bugfix changes.
 
-The main yield-generator.py script has been renamed to 
+The main yield-generator.py script has been renamed to
 `yield-generator-basic.py`, the new-yieldgen-algo variant which was previously on a different
 git branch has been renamed to `yield-generator-mixdepth.py` and a third variant called
 `yield-generator-deluxe.py` has been created.
@@ -94,11 +94,11 @@ be seen from reading the top of the script.
 Change to 'internal/external' branches from 'for change/receive'
 -----------------------------------
 
-See [368](https://github.com/joinmarket-org/joinmarket/issues/368) fixing 
-[283](https://github.com/joinmarket-org/joinmarket/issues/283). 
+See [368](https://github.com/joinmarket-org/joinmarket/issues/368) fixing
+[283](https://github.com/joinmarket-org/joinmarket/issues/283).
 There is a possibility of address reuse if coins are added
 to a mixdepth in the receive branch, while that address is also chosen by a bot for use.
-This led to this improvement of the design: 'external' branch is only added to by the 
+This led to this improvement of the design: 'external' branch is only added to by the
 user from outside sources, while the bot itself will only choose new addresses from the
 'internal' branch. The user merely has to bear in mind that they should only add coins
 to the 'external' branch, just as before they were advised only to add coins to the
@@ -120,19 +120,19 @@ with any script except `wallet-tool.py`.
 =================
 
 For the first release, this will be a list of the notable changes since
-[the last significant update to the master branch](https://github.com/JoinMarket-Org/joinmarket/commit/2ef37996f90d3c4ea3ca7880a1619a182e710e67). 
+[the last significant update to the master branch](https://github.com/JoinMarket-Org/joinmarket/commit/2ef37996f90d3c4ea3ca7880a1619a182e710e67).
 Minor string fixes or test updates are not included. In future, this section will be
 a list of all functional changes since the previous release.
 
 - #345 `77cf5fa` Complete code refactoring. See #340 #345 for details on verification.
 - #346 `3b3c05d` dynamic fee calculation, including sweep, and tumbler, and test updates
 - #356 `0d7f14b` refactoring for yieldgens: new variants, see also #353 #357 #371
 - #361 `f71b2db`  reduce DOS possibility via orderbook calls, see issue 298
-- #366 `a33a851`  throttling with Queue 
-- #367 `5322791`  add confirmation-spendability knob for bitcoind-rpc 
-- #368 `f90e992`  Restructure for_change HD branch as {in,ex}ternal 
+- #366 `a33a851`  throttling with Queue
+- #367 `5322791`  add confirmation-spendability knob for bitcoind-rpc
+- #368 `f90e992`  Restructure for_change HD branch as {in,ex}ternal
 - #369 `1537d3e`  Handle pushtx failures. Catch jsonrpcerror exception and retry for tumbler
-- #372 `9b809db`  Add gaplimit option for sendpayment.py. 
+- #372 `9b809db`  Add gaplimit option for sendpayment.py.
 
 
 Credits
@@ -148,5 +148,3 @@ Thanks to everyone who directly contributed to this release:
 - @domob1812
 
 And those who contributed additional code review, ideas and comments.
-
-

doc/release-notes-0.1.1.md

@@ -28,8 +28,8 @@ Preventing failure on receipt of invalid orders
 
 See [391](https://github.com/joinmarket-org/joinmarket/issues/391) and
 [390](https://github.com/joinmarket-org/joinmarket/issues/390).
-Makers publishing orders with non-integer amounts for an `absorder` were causing 
-a ValueError exception to be raised, preventing Takers from running successfully. 
+Makers publishing orders with non-integer amounts for an `absorder` were causing
+a ValueError exception to be raised, preventing Takers from running successfully.
 This fix prevents that.
 
 
@@ -38,5 +38,3 @@ This fix prevents that.
 
 
 - #391 `7f5e06e` Disallow non-integer absorder in on_order_seen.
-
-

doc/release-notes-0.1.2.md

@@ -30,7 +30,7 @@ Returning the alert system to JoinMarket after it was mistakenly removed in a re
 ------------------------------------
 
 See [400](https://github.com/joinmarket-org/joinmarket/issues/400)
-Anybody announcing a command to cancel an order without an order id would cause 
+Anybody announcing a command to cancel an order without an order id would cause
 all bots to crash
 This fix prevents that.
 
@@ -43,4 +43,3 @@ This fix prevents that.
 - #387 `77ef4b4` clump coins differently in yieldgenerator to increase privacy
 - #397 `6ced862` fix issue 395 about accidental negative fees in yieldgenerator deluxe
 - #392 `00ef236` fix issue #392
-

doc/release-notes-0.1.4.md

@@ -31,7 +31,7 @@ case it cannot be installed, joinmarket should continue to run exactly as before
 
 On Linux it can be installed with
 
-	pip install secp256k1
+        pip install secp256k1
 
 For past discussion on this feature which may be helpful, see this reddit thread
 
@@ -69,11 +69,11 @@ work out the effective annual interest rate, as though yield-generator was a sav
 To use, configure JoinMarket to use a Bitcoin node as a method of accessing the blockchain
 and run:
 
-	python wallet-tool.py wallet.json history
+        python wallet-tool.py wallet.json history
 
 A csv file can be created for opening with spreadsheet software too:
 
-	python wallet-tool.py --csv wallet.json history > history.csv
+        python wallet-tool.py --csv wallet.json history > history.csv
 
 
 0.1.4 Change log
@@ -83,35 +83,35 @@ Tumbler Stability:
 - `671edcc` Restored debug_silence, so tumbler Insert New Address prompt can be seen
 - `76d9071` Increased scope of timeout_thread_lock to stop a rare race condition
 - `440357a` Fee calculation for sweep orders excludes miner fees, fixing #441
-- `e47f47d` Fix not enough funds exception catch in tumbler 
+- `e47f47d` Fix not enough funds exception catch in tumbler
 - `8af1376` Caught exception around getrawtransaction in the case of wallet conflicts
 - `2dc3437` Create the confirm timeout feature of blockchaininterface, modified tumbler.py to use it
 - `04c277e` Added sync_unspent() to tumbler create_tx() to reduce likelyhood of wallet being out of sync
 - `fc3b6a3` Made tumbler update wallet file index cache, so wallet-tool display will reach the right mixdepths
 - `00ac1a1` Clear irc.built_privmsg on reconnect, which prevents crashes from junk being passed to base64 decode
-- `e4ff93d` Added check to make sure tumbler coins reach every destination address 
+- `e4ff93d` Added check to make sure tumbler coins reach every destination address
 
 Features:
 - `42917f5` Always load default config with initial values first, then load potential config file afterwards
 - `0f0631d` Created script broadcast-tx.py for broadcasting transactions via makers
 - `22adabc` Gave names to all the threads so they appear in debug logs
 - `4c08910` Adjuste IRC throttle parameters, experimentally derived
 - `d82668d` maker_timeout_sec is readjusted for the second stage (!tx sending) based on transaction size, and IRC throttling variables are module vars
-- `98db29f` Add yield-generator-oscillator 
+- `98db29f` Add yield-generator-oscillator
 - `bf140fa` Bump default makercount to randint(2,4)
 - `99ea24f` New re-integration of secp256k1 via ludbb binding
 - `c70214d` Wallet history
 - `1c20bfc` Options for broadcasting transactions via makers, issue #56
 - `e7c1bf1` Show xpub keys in wallet-tool display, issue #493
 
 Bugfixes:
-- `d2be6c2` Recover from selection of spent utxos 
+- `d2be6c2` Recover from selection of spent utxos
 - `184f2fe` Stop yield-generator-mixdepth announcing absorders if they havent been modified
 - `96cff63` Fix crash in yield generator mixdepth when no unconfirm notify arrives
 - `b814d3f` BitcoinCoreInterface now guarentees that unconfirmfun() will always be invoked, issue #436
 - `388d833` Wrapped close() in try: except to stop it crashing the throttle thread
 - `e7cb86d` Prevent offer minsize from going below DUST_THRESHOLD, issue #382
-- `b9a673b` Added explaination to patientsendpayment in case anyone uses it 
+- `b9a673b` Added explaination to patientsendpayment in case anyone uses it
 - `d650be6` Add length check to address validation; should be 20 bytes for both p2pkh and p2sh after stripping checksum and version
 
 
@@ -123,8 +123,8 @@ Thanks to everyone who directly contributed to this release
 - @AdamISZ
 - @adlai
 - @chris-belcher
-- @OverlordQ 
-- @raedah 
+- @OverlordQ
+- @raedah
 - @veqtrus
 
 And those who contributed additional code review, ideas, debug logs and comments.