Add subprocess tests

Author: NathanVaughn

tests/test_executor/test_task_cwd/test_task_cwd.py

@@ -1,7 +1,10 @@
 from pathlib import Path
 
+import pytest
+
 from tests.conftest import task_obj
 from vscode_task_runner import executor
+from vscode_task_runner.exceptions import WorkingDirectoryNotFound
 
 
 def test_full(linux: None, pathlib_is_dir_true: None) -> None:
@@ -38,3 +41,10 @@ def test_partial5(linux: None, pathlib_is_dir_true: None) -> None:
     task.linux = None
 
     assert executor.task_cwd(task) == Path("/value2")
+
+
+def test_directroy_not_found() -> None:
+    task = task_obj(__file__, "cwd-test")
+
+    with pytest.raises(WorkingDirectoryNotFound):
+        executor.task_cwd(task)

tests/test_executor/test_task_env/test_task_env.py

@@ -1,3 +1,5 @@
+import pytest
+
 from tests.conftest import task_obj
 from vscode_task_runner import executor
 
@@ -43,3 +45,19 @@ def test_partial5(linux: None) -> None:
     task.linux = None
 
     assert executor._new_task_env(task) == {"TEST1": "value1", "TEST2": "value2"}
+
+
+@pytest.mark.parametrize(
+    "environment_variable",
+    [("TEST3", "oldvalue")],
+    indirect=True,
+)
+def test_task_env(environment_variable: None) -> None:
+    """
+    Test that the task environment is merged with the current environment.
+    """
+    task = task_obj(__file__, "env-test")
+    env = executor.task_env(task)
+    assert env["TEST3"] == "value3"
+    # moer than just test3 and 4
+    assert len(env) >= 2

tests/test_executor/test_task_env_types/.vscode/tasks.json

@@ -0,0 +1,20 @@
+{
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "test1",
+            "command": "echo $TEST1 $TEST2 $TEST3",
+            "type": "shell",
+        },
+        {
+            "label": "test2",
+            "command": "echo $TEST1 $TEST2 $TEST3",
+            "type": "shell",
+            "dependsOn": "test1",
+        },
+        {
+            "label": "test3",
+            "dependsOn": "test1",
+        },
+    ]
+}

tests/test_executor/test_task_env_types/test_task_env_types.py

@@ -0,0 +1,13 @@
+from tests.conftest import task_obj
+from vscode_task_runner import executor
+
+
+def test_is_virtual_task() -> None:
+    t1 = task_obj(__file__, "test1")
+    assert executor.is_virtual_task(t1) is False
+
+    t2 = task_obj(__file__, "test2")
+    assert executor.is_virtual_task(t2) is False
+
+    t3 = task_obj(__file__, "test3")
+    assert executor.is_virtual_task(t3) is True

tests/test_executor/test_task_is_virtual/.vscode/tasks.json

@@ -0,0 +1,42 @@
+{
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "1",
+            "type": "process",
+            "command": "echo",
+            "args": ["hello world"]
+        },
+        {
+            "label": "2",
+            "type": "shell",
+            "command": "echo 'hello world'",
+            "options": {"shell": {
+                "executable": "bash",
+                "args": ["-c"]
+            }}
+        },
+        {
+            "label": "3",
+            "type": "shell",
+            "command": "echo",
+            "args": ["hello world"],
+            "options": {"shell": {
+                "executable": "bash",
+                "args": ["-c"]
+            }}
+        },
+        {
+            "label": "4",
+            "type": "shell",
+            "command": {"value": "echo 'hello world'", "quoting": "weak"},
+            "options": {"shell": {
+                "executable": "bash",
+                "args": ["-c"]
+            }}
+        },
+        {
+            "label": "5",
+        },
+    ]
+}

tests/test_executor/test_task_is_virtual/test_task_is_virtual.py

@@ -0,0 +1,64 @@
+import pytest
+
+from tests.conftest import task_obj
+from vscode_task_runner import executor
+from vscode_task_runner.exceptions import MissingCommand
+
+
+@pytest.mark.parametrize(
+    "label, expected",
+    [
+        (
+            "1",
+            ["echo", "hello world"],
+        ),
+        (
+            "2",
+            ["bash", "-c", "echo 'hello world'"],
+        ),
+    ],
+)
+def test_task_subprocess_command(
+    label: str, expected: list[str], shutil_which_patch: None
+) -> None:
+    task = task_obj(__file__, label)
+
+    assert executor.task_subprocess_command(task) == expected
+
+
+@pytest.mark.parametrize(
+    "label, expected",
+    [
+        (
+            "1",
+            ["echo", "hello world", "--verbose"],
+        ),
+        (
+            "2",
+            ["bash", "-c", "echo 'hello world' --verbose"],
+        ),
+        (
+            "3",
+            ["bash", "-c", "echo 'hello world' --verbose"],
+        ),
+        (
+            "4",
+            ["bash", "-c", "\"echo 'hello world' --verbose\""],
+        ),
+    ],
+)
+def test_task_subprocess_command_extra_args(
+    label: str, expected: list[str], shutil_which_patch: None
+) -> None:
+    task = task_obj(__file__, label)
+
+    assert executor.task_subprocess_command(task, extra_args=["--verbose"]) == expected
+
+
+def test_task_subprocess_command_no_command(
+    shutil_which_patch: None,
+) -> None:
+    task = task_obj(__file__, "5")
+
+    with pytest.raises(MissingCommand):
+        executor.task_subprocess_command(task)