Build is non-deterministic, failed 4 times in different places

[mtnygard]

Reported as of commit 6a7ee812c7.

I've pasted a transcript as this gist.

All of the builds were executed in a single shell, with the same build command: ./gradlew clean build.

The builds all failed for different reasons, suggesting timing dependencies in the unit tests.

[mtnygard]

Note that the build failure reported in #327 is one of the errors I encountered.

[mtnygard]

More detail: this seems to be a Java 8 issue. It builds clean with 1.6.

[benjchristensen]

I have committed fixes for these that should behave better. There were legit issues in them that depended on specific machine and scheduler timing. I won't be surprised if there are other tests with similar issues in the codebase.

[benjchristensen]

Considering this closed ... reopen if you're still seeing these issues.