bpo-43979: Remove unnecessary operation from urllib.parse.parse_qsl (pythonGH-25756)

corona10 · web-flow · commit 6143fcdf8bfe · 2021-04-30T12:01:55.000-07:00
Automerge-Triggered-By: GH:gpshead
diff --git a/Lib/urllib/parse.py b/Lib/urllib/parse.py
@@ -752,9 +752,8 @@ def parse_qsl(qs, keep_blank_values=False, strict_parsing=False,
         if max_num_fields < num_fields:
             raise ValueError('Max number of fields exceeded')
 
-    pairs = [s1 for s1 in qs.split(separator)]
     r = []
-    for name_value in pairs:
+    for name_value in qs.split(separator):
         if not name_value and not strict_parsing:
             continue
         nv = name_value.split('=', 1)
diff --git a/Misc/NEWS.d/next/Library/2021-05-01-01-36-51.bpo-43979.43oJ9L.rst b/Misc/NEWS.d/next/Library/2021-05-01-01-36-51.bpo-43979.43oJ9L.rst
@@ -0,0 +1,2 @@
+Removed an unnecessary list comprehension before looping from
+:func:`urllib.parse.parse_qsl`.  Patch by Christoph Zwerschke and Dong-hee Na.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Removed an unnecessary list comprehension before looping from`
	`2`	+:func:`urllib.parse.parse_qsl`. Patch by Christoph Zwerschke and Dong-hee Na.