Make sure that the start date / time doesn't exceed the end date / time

Author: izeigerman

sqlmesh/cli/__init__.py

@@ -15,7 +15,7 @@ def wrapper(*args, **kwargs):
             return func(*args, **kwargs)
         except NodeExecutionFailedError as ex:
             raise click.ClickException(str(ex.__cause__))
-        except (SQLMeshError, SqlglotError) as ex:
+        except (SQLMeshError, SqlglotError, ValueError) as ex:
             raise click.ClickException(str(ex))
 
     return wrapper

sqlmesh/core/model.py

@@ -470,7 +470,7 @@ def _date_validator(cls, v: t.Any) -> t.Optional[TimeLike]:
         if isinstance(v, exp.Expression):
             v = v.name
         if not to_datetime(v):
-            raise ConfigError(f"{v} not a valid date time")
+            raise ConfigError(f"'{v}' not a valid date time")
         return v
 
     @validator("batch_size", pre=True)
@@ -727,7 +727,6 @@ def load(
 
         if not query.expressions:
             _raise_config_error("Query missing select statements", path)
-            raise
 
         try:
             model = cls(

sqlmesh/core/plan.py

@@ -45,7 +45,7 @@
 )
 from sqlmesh.core.state_sync import StateReader
 from sqlmesh.utils import random_id
-from sqlmesh.utils.date import TimeLike, make_inclusive, now, to_ds
+from sqlmesh.utils.date import TimeLike, make_inclusive, now, to_ds, validate_date_range
 from sqlmesh.utils.errors import SQLMeshError
 from sqlmesh.utils.pydantic import PydanticModel
 
@@ -206,6 +206,7 @@ def apply(self) -> None:
         """Runs apply if an apply function was passed in."""
         if not self._apply:
             raise SQLMeshError(f"Plan was not initialized with an applier.")
+        validate_date_range(self.start, self.end)
         self._apply(self)
 
     def set_choice(self, snapshot: Snapshot, choice: SnapshotChangeCategory) -> None:

sqlmesh/core/scheduler.py

@@ -11,7 +11,13 @@
 from sqlmesh.core.snapshot_evaluator import SnapshotEvaluator
 from sqlmesh.core.state_sync import StateSync
 from sqlmesh.utils.concurrency import NodeExecutionFailedError, concurrent_apply_to_dag
-from sqlmesh.utils.date import TimeLike, now, to_datetime, yesterday
+from sqlmesh.utils.date import (
+    TimeLike,
+    now,
+    to_datetime,
+    validate_date_range,
+    yesterday,
+)
 
 logger = logging.getLogger(__name__)
 SnapshotBatches = t.List[t.Tuple[Snapshot, t.List[t.Tuple[datetime, datetime]]]]
@@ -66,6 +72,7 @@ def evaluate(
             latest: The latest datetime to use for non-incremental queries.
             kwargs: Additional kwargs to pass to the renderer.
         """
+        validate_date_range(start, end)
 
         mapping = {
             **{
@@ -107,6 +114,8 @@ def run(
             end: The end of the run. Defaults to now.
             latest: The latest datetime to use for non-incremental queries.
         """
+        validate_date_range(start, end)
+
         latest = latest or now()
         batches = self.interval_params(self.snapshots.values(), start, end, latest)
 

sqlmesh/utils/date.py

@@ -242,3 +242,13 @@ def preserve_time_like_kind(input_value: TimeLike, output_value: TimeLike) -> Ti
     if is_date(input_value):
         return to_date(output_value)
     return output_value
+
+
+def validate_date_range(
+    start: t.Optional[TimeLike],
+    end: t.Optional[TimeLike],
+) -> None:
+    if start and end and to_datetime(start) > to_datetime(end):
+        raise ValueError(
+            f"Start date / time ({start}) can't be greater than end date / time ({end})"
+        )