Skip to content

feat: integrate callback saving into integrator init and finalize #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Sep 3, 2025
Merged

feat: integrate callback saving into integrator init and finalize #331

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d8fbca
feat: integrate callback saving into integrator init and finalize
AayushSabharwal Aug 25, 2025
701e5c0
build: bump SciMLBase, DiffEqBase, OrdinaryDiffEqCore compats
AayushSabharwal Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: integrate callback saving into integrator init and finalize
  • Loading branch information
@AayushSabharwal
AayushSabharwal committed Sep 3, 2025
commit 5d8fbcab112425533b59c9e1e943b67d1b006961
3 changes: 3 additions & 0 deletions src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,9 @@ function SciMLBase.__init(prob::SciMLBase.AbstractDDEProblem,
SciMLBase.initialize_dae!(integrator)
initialize_solution!(integrator)
OrdinaryDiffEqCore.initialize_callbacks!(integrator, initialize_save)
if save_on && save_start
SciMLBase.save_discretes_if_enabled!(integrator, opts.callback; skip_duplicates = true)
end
DiffEqBase.initialize!(integrator)
end

Expand Down