apply rector

Author: TomasVotruba

src/AstCognitiveComplexityAnalyzer.php

@@ -19,9 +19,9 @@
 final class AstCognitiveComplexityAnalyzer
 {
     public function __construct(
-        private ComplexityNodeTraverserFactory $complexityNodeTraverserFactory,
-        private CognitiveComplexityDataCollector $cognitiveComplexityDataCollector,
-        private NestingNodeVisitor $nestingNodeVisitor
+        private readonly ComplexityNodeTraverserFactory $complexityNodeTraverserFactory,
+        private readonly CognitiveComplexityDataCollector $cognitiveComplexityDataCollector,
+        private readonly NestingNodeVisitor $nestingNodeVisitor
     ) {
     }
 

src/Exception/ShouldNotHappenException.php

@@ -4,6 +4,8 @@
 
 namespace TomasVotruba\CognitiveComplexity\Exception;
 
-class ShouldNotHappenException extends \Exception
+use Exception;
+
+final class ShouldNotHappenException extends Exception
 {
 }

src/NodeTraverser/ComplexityNodeTraverserFactory.php

@@ -11,8 +11,8 @@
 final class ComplexityNodeTraverserFactory
 {
     public function __construct(
-        private NestingNodeVisitor $nestingNodeVisitor,
-        private ComplexityNodeVisitor $complexityNodeVisitor
+        private readonly NestingNodeVisitor $nestingNodeVisitor,
+        private readonly ComplexityNodeVisitor $complexityNodeVisitor
     ) {
     }
 

src/NodeVisitor/ComplexityNodeVisitor.php

@@ -12,8 +12,8 @@
 final class ComplexityNodeVisitor extends NodeVisitorAbstract
 {
     public function __construct(
-        private CognitiveComplexityDataCollector $cognitiveComplexityDataCollector,
-        private ComplexityAffectingNodeFinder $complexityAffectingNodeFinder
+        private readonly CognitiveComplexityDataCollector $cognitiveComplexityDataCollector,
+        private readonly ComplexityAffectingNodeFinder $complexityAffectingNodeFinder
     ) {
     }
 

src/NodeVisitor/NestingNodeVisitor.php

@@ -38,8 +38,8 @@ final class NestingNodeVisitor extends NodeVisitorAbstract
     private int $previousNestingLevel = 0;
 
     public function __construct(
-        private CognitiveComplexityDataCollector $cognitiveComplexityDataCollector,
-        private ComplexityAffectingNodeFinder $complexityAffectingNodeFinder,
+        private readonly CognitiveComplexityDataCollector $cognitiveComplexityDataCollector,
+        private readonly ComplexityAffectingNodeFinder $complexityAffectingNodeFinder,
     ) {
     }
 

src/Rules/ClassLikeCognitiveComplexityRule.php

@@ -23,7 +23,7 @@ final class ClassLikeCognitiveComplexityRule implements Rule
     public const ERROR_MESSAGE = 'Class cognitive complexity is %d, keep it under %d';
 
     public function __construct(
-        private AstCognitiveComplexityAnalyzer $astCognitiveComplexityAnalyzer,
+        private readonly AstCognitiveComplexityAnalyzer $astCognitiveComplexityAnalyzer,
         private readonly Configuration $configuration
     ) {
     }

src/Rules/FunctionLikeCognitiveComplexityRule.php

@@ -14,6 +14,7 @@
 use PHPStan\Rules\Rule;
 use TomasVotruba\CognitiveComplexity\AstCognitiveComplexityAnalyzer;
 use TomasVotruba\CognitiveComplexity\Configuration;
+use TomasVotruba\CognitiveComplexity\Exception\ShouldNotHappenException;
 
 /**
  * Based on https://www.sonarsource.com/docs/CognitiveComplexity.pdf
@@ -35,8 +36,8 @@ final class FunctionLikeCognitiveComplexityRule implements Rule
     public const ERROR_MESSAGE = 'Cognitive complexity for "%s" is %d, keep it under %d';
 
     public function __construct(
-        private AstCognitiveComplexityAnalyzer $astCognitiveComplexityAnalyzer,
-        private Configuration $configuration,
+        private readonly AstCognitiveComplexityAnalyzer $astCognitiveComplexityAnalyzer,
+        private readonly Configuration $configuration,
     ) {
     }
 
@@ -100,6 +101,6 @@ private function resolveFunctionName(FunctionLike $functionLike, Scope $scope):
             return 'arrow function';
         }
 
-        throw new \TomasVotruba\CognitiveComplexity\Exception\ShouldNotHappenException();
+        throw new ShouldNotHappenException();
     }
 }