Added Rule error identifiers #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
the rector GH action fail looks unrelated |
…precated. Use Type::getObjectClassNames() or Type::getObjectClassReflections() instead.
staabm
commented
Dec 12, 2024
| "php": "^8.2", | ||
| "phpstan/phpstan": "^1.10.50" | ||
| "phpstan/phpstan": "^1.10.50", | ||
| "nikic/php-parser": "^4" |
Contributor
Author
There was a problem hiding this comment.
stick to php-parser v4 as otherwise v5 would be installed automatically and be in conflict with rector v1 and phpstan v1
staabm
commented
Dec 12, 2024
| $parameterClassReflection = $parameterType->getClassReflection(); | ||
| if (! $parameterClassReflection instanceof ClassReflection) { | ||
| $classReflections = $parameterType->getObjectClassReflections(); | ||
| // XXX add support for union types |
Contributor
Author
There was a problem hiding this comment.
unions were not supported before this PR either. just making the TODO explicit for now
Owner
|
Looks good to me, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eases migration to PHPStan 2.x while staying compatible with PHPStan 1.x for now