Skip to content

Commit f699a73

Browse files
author
David Scott
committed
Remove the hardcoded disabling of ballooning for dom0
To express "don't balloon me", set the dynamic-min and dynamic-max to the same values. Signed-off-by: David Scott <[email protected]>
1 parent d6408a9 commit f699a73

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

ocaml/xapi/helpers.ml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -605,10 +605,6 @@ let pool_has_different_host_platform_versions ~__context =
605605
let is_different_to_me platform_version = platform_version <> Version.platform_version in
606606
List.fold_left (||) false (List.map is_different_to_me platform_versions)
607607

608-
(** Indicates whether ballooning is enabled for the given virtual machine. *)
609-
let ballooning_enabled_for_vm ~__context vm_record =
610-
not vm_record.API.vM_is_control_domain
611-
612608
let get_vm_metrics ~__context ~self =
613609
let metrics = Db.VM.get_metrics ~__context ~self in
614610
if metrics = Ref.null

ocaml/xapi/memory_check.ml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,11 @@ type accounting_policy =
5656
(** use dynamic_min: liberal: assumes that guests always co-operate. *)
5757

5858
(** Common logic of vm_compute_start_memory and vm_compute_used_memory *)
59-
let choose_memory_required ~policy ~ballooning_enabled ~memory_dynamic_min ~memory_dynamic_max ~memory_static_max =
60-
match (ballooning_enabled, policy) with
61-
| (true, Dynamic_min) -> memory_dynamic_min
62-
| (true, Dynamic_max) -> memory_dynamic_max
63-
| (false, Dynamic_min)
64-
| (false, Dynamic_max)
65-
| (_, Static_max) -> memory_static_max
59+
let choose_memory_required ~policy ~memory_dynamic_min ~memory_dynamic_max ~memory_static_max =
60+
match policy with
61+
| Dynamic_min -> memory_dynamic_min
62+
| Dynamic_max -> memory_dynamic_max
63+
| Static_max -> memory_static_max
6664

6765
(** Calculates the amount of memory required in both 'normal' and 'shadow'
6866
memory, to start a VM. If the given VM is a PV guest and if memory ballooning
@@ -77,7 +75,6 @@ let vm_compute_start_memory ~__context ?(policy=Dynamic_min) vm_record =
7775
else
7876
let memory_required = choose_memory_required
7977
~policy: policy
80-
~ballooning_enabled: (Helpers.ballooning_enabled_for_vm ~__context vm_record)
8178
~memory_dynamic_min: vm_record.API.vM_memory_dynamic_min
8279
~memory_dynamic_max: vm_record.API.vM_memory_dynamic_max
8380
~memory_static_max: vm_record.API.vM_memory_static_max in
@@ -95,7 +92,6 @@ let vm_compute_used_memory ~__context policy vm_ref =
9592

9693
let memory_required = choose_memory_required
9794
~policy: policy
98-
~ballooning_enabled: (Helpers.ballooning_enabled_for_vm ~__context vm_boot_record)
9995
~memory_dynamic_min: vm_main_record.API.vM_memory_dynamic_min
10096
(* ToDo: Is vm_main_record or vm_boot_record the right thing for dynamic_max? *)
10197
~memory_dynamic_max: vm_main_record.API.vM_memory_dynamic_max

0 commit comments

Comments
 (0)