add test case for invalid JSON response body

Author: mkdynamic

lib/Client.js

@@ -65,7 +65,7 @@ merge(Client.prototype, {
             try {
               wrapper.body = serializer.load(buffer, resources);
             } catch (err) {
-              return reject(errors());
+              reject(errors('client', 'failed to parse response: "' + buffer + '"'));
               return;
             }
           }

lib/Errors.js

@@ -15,7 +15,8 @@ var errors = {
   '406': constructError('UnsupportedFormatRequestedError'),
   '422': constructError('ResourceValidationError'),
   '500': constructError('GeneralAPIError'),
-  '503': constructError('ServiceUnavailableError')
+  '503': constructError('ServiceUnavailableError'),
+  'client': constructError('GeneralClientError')
 };
 
 module.exports = function(status, message) {

test/client_test.js

@@ -79,5 +79,15 @@ describe('Client', function() {
         expect(response.body).to.eql(undefined);
       });
     });
+
+    it('rejects invalid JSON response body', function() {
+      var client = new Client(helper.config);
+
+      return client.get('/invalid_json').then(function(_) {
+        expect(false).to.be(true);
+      }, function(error) {
+        expect(error.type).to.eq('GeneralClientError');
+      });
+    });
   });
 });

test/test_helper.js

@@ -91,6 +91,11 @@ var requests = {
   'GET /empty_body': {
     status: 200,
     body_raw: ''
+  },
+
+  'GET /invalid_json': {
+    status: 200,
+    body_raw: '{"invalid_json":123'
   }
 };