Skip to content

Commit f474f95

Browse files
committed
Expanding PCI classes that count as storage devices to include Fibre CHannel and Infiband codes.
Signed-off-by: Rob Dobson <[email protected]>
1 parent 7832375 commit f474f95

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

hwinfo/tools/inspector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def pci_filter_for_nics(devices):
170170
return pci_filter(devices, nic_types)
171171

172172
def pci_filter_for_storage(devices):
173-
storage_types = ['00', '01']
173+
storage_types = ['00', '01', '0c04', '0c06']
174174
return pci_filter(devices, storage_types)
175175

176176
def pci_filter_for_gpu(devices):

hwinfo/tools/tests/test_inspector.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,15 @@ def setUp(self):
9797
device_b = mock.MagicMock()
9898
device_c = mock.MagicMock()
9999
device_d = mock.MagicMock()
100+
device_e = mock.MagicMock()
100101

101102
device_a.get_pci_class.return_value = '0230'
102103
device_b.get_pci_class.return_value = '0340'
103104
device_c.get_pci_class.return_value = '0210'
104105
device_d.get_pci_class.return_value = '0100'
106+
device_e.get_pci_class.return_value = '0c04'
105107

106-
self.devices = [device_a, device_b, device_c, device_d]
108+
self.devices = [device_a, device_b, device_c, device_d, device_e]
107109

108110
def test_pci_filter_match_all(self):
109111
devs = inspector.pci_filter(self.devices, ['0'])
@@ -130,8 +132,7 @@ def test_pci_filter_for_nics(self):
130132

131133
def test_pci_filter_for_storage(self):
132134
devs = inspector.pci_filter_for_storage(self.devices)
133-
self.assertEqual(len(devs), 1)
134-
self.assertEqual(devs[0].get_pci_class(), '0100')
135+
self.assertEqual(len(devs), 2)
135136

136137
def test_pci_filter_for_gpu(self):
137138
devs = inspector.pci_filter_for_gpu(self.devices)

0 commit comments

Comments
 (0)