This repository was archived by the owner on May 29, 2019. It is now read-only.
if tabset is being destroyed, don't 'select' tabs#2596
Closed
tfranceuk wants to merge 1 commit intoangular-ui:masterfrom
Closed
if tabset is being destroyed, don't 'select' tabs#2596tfranceuk wants to merge 1 commit intoangular-ui:masterfrom
tfranceuk wants to merge 1 commit intoangular-ui:masterfrom
Conversation
Member
|
@tfranceuk thnx, this looks reasonable. Could you please add a test for this issue? |
Contributor
|
I've added a test for this to my fork: widgetworks/bootstrap@bcdaee3 Should @tfranceuk merge this into their pull request or should I create a new one? |
Contributor
|
@Coridyn , feel free to make a new one. You've cherry-picked @tfranceuk 's fix so it'll be the same either way. 👍 |
ulle
pushed a commit
to ulle/bootstrap
that referenced
this pull request
Oct 22, 2014
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a tabset is being destroyed, each of the subsequent tabs is selected as the previous one is destroyed.