|
1 | 1 | load("//:packages.bzl", "ALL_PACKAGES", "to_package_label") |
2 | 2 | load("@build_bazel_rules_nodejs//internal/linker:npm_link.bzl", "npm_link") |
| 3 | +load("@build_bazel_rules_nodejs//:providers.bzl", "LinkablePackageInfo") |
| 4 | +load("@build_bazel_rules_nodejs//internal/linker:link_node_modules.bzl", "LinkerPackageMappingInfo") |
3 | 5 |
|
4 | | -def link_local_packages(deps): |
5 | | - """Stamp npm_link targets for packages in deps that has a local package equivalent. |
| 6 | +def _is_angular_dep(dep): |
| 7 | + """Check if a dep , e.g., @aio_npm//@angular/core corresonds to a local Angular pacakge.""" |
| 8 | + return dep.startswith("@aio_npm//") and _angular_dep_to_pkg_name(dep) in ALL_PACKAGES |
| 9 | + |
| 10 | +def _angular_dep_to_pkg_name(dep): |
| 11 | + """E.g., @aio_npm//@angular/core => '@angular/core'""" |
| 12 | + label = Label(dep) |
| 13 | + return label.package |
| 14 | + |
| 15 | +def link_local_packages(all_aio_deps): |
| 16 | + """Create targets needed for building AIO against local angular packages. |
| 17 | +
|
| 18 | + Creates targets that link Angular packages, as well as targets to be used |
| 19 | + in place of any deps required to build and test AIO. These targets filter |
| 20 | + out any transitive deps on the npm packages and must be used in place of |
| 21 | + any original list of deps. |
| 22 | +
|
| 23 | + Use the helper `substitute_local_package_deps()` to translate a list of deps |
| 24 | + to the equivalent "filtered" target that this rule creates. |
6 | 25 |
|
7 | 26 | Args: |
8 | | - deps: list of npm dependency labels |
| 27 | + all_aio_deps: label list of all deps required to build and test AIO |
9 | 28 | """ |
10 | | - for dep in deps: |
11 | | - if dep.startswith("@aio_npm//"): |
12 | | - label = Label(dep) |
13 | | - if label.package in ALL_PACKAGES: |
14 | | - npm_link( |
15 | | - name = _npm_link_name(dep), |
16 | | - target = to_package_label(label.package), |
17 | | - package_name = label.package, |
18 | | - package_path = native.package_name(), |
19 | | - tags = ["manual"], |
20 | | - ) |
21 | | - |
22 | | -def substitute_local_packages(deps): |
23 | | - """Substitute npm dependencies for their local npm_link equivalent. |
24 | | -
|
25 | | - Assumes that link_local_packages() was already called on these dependencies. |
26 | | - Dependencies that are not associated with a local package are left alone. |
| 29 | + |
| 30 | + aio_angular_deps = [dep for dep in all_aio_deps if _is_angular_dep(dep)] |
| 31 | + angular_packages = [_angular_dep_to_pkg_name(dep) for dep in aio_angular_deps] |
| 32 | + |
| 33 | + # Link local angular packages in place of their npm equivalent |
| 34 | + for dep in aio_angular_deps: |
| 35 | + pkg_name = _angular_dep_to_pkg_name(dep) |
| 36 | + npm_link( |
| 37 | + name = _npm_link_name(pkg_name), |
| 38 | + target = to_package_label(pkg_name), |
| 39 | + package_name = pkg_name, |
| 40 | + package_path = native.package_name(), |
| 41 | + tags = ["manual"], |
| 42 | + ) |
| 43 | + |
| 44 | + # Special case deps that must be testonly |
| 45 | + testonly_deps = [ |
| 46 | + "@aio_npm//@angular/build-tooling/bazel/browsers/chromium", |
| 47 | + ] |
| 48 | + |
| 49 | + # Stamp a corresponding target for each AIO dep that filters out transitive |
| 50 | + # dependencies on angular npm packages. This help the rules_nodejs linker, |
| 51 | + # which fails to link local packages a transitive dependency on the npm |
| 52 | + # package exists. |
| 53 | + for dep in all_aio_deps: |
| 54 | + target = dep |
| 55 | + if dep in aio_angular_deps: |
| 56 | + pkg_name = _angular_dep_to_pkg_name(dep) |
| 57 | + |
| 58 | + # We don't need to filter transitives on local packages as they depend |
| 59 | + # on each other locally. |
| 60 | + native.alias( |
| 61 | + name = _filtered_transitives_name(dep), |
| 62 | + actual = ":%s" % _npm_link_name(pkg_name), |
| 63 | + tags = ["manual"], |
| 64 | + ) |
| 65 | + else: |
| 66 | + filter_transitive_angular_deps( |
| 67 | + name = _filtered_transitives_name(dep), |
| 68 | + target = target, |
| 69 | + angular_packages = angular_packages, |
| 70 | + testonly = True if dep in testonly_deps else False, |
| 71 | + tags = ["manual"], |
| 72 | + ) |
| 73 | + |
| 74 | +def substitute_local_package_deps(deps): |
| 75 | + """Substitute AIO dependencies with an equivalent target that filters |
| 76 | + out any transitive npm dependencies. You should call link_local_packages() |
| 77 | + to actually stamp the targets first. |
27 | 78 |
|
28 | 79 | Args: |
29 | | - deps: list of npm dependency labels |
| 80 | + deps: list of AIO dependencies |
30 | 81 |
|
31 | 82 | Returns: |
32 | 83 | substituted list of dependencies |
33 | 84 | """ |
34 | | - substituted = [] |
35 | | - for dep in deps: |
36 | | - if dep.startswith("@aio_npm//"): |
37 | | - label = Label(dep) |
38 | | - if label.package in ALL_PACKAGES: |
39 | | - substituted.append(_npm_link_name(dep)) |
40 | | - continue |
41 | | - |
42 | | - substituted.append(dep) |
43 | | - return substituted |
44 | | - |
45 | | -def _npm_link_name(dep): |
46 | | - label = Label(dep) |
47 | | - return "local_%s" % label.package.replace("@", "_").replace("/", "_") |
| 85 | + |
| 86 | + return [":%s" % _filtered_transitives_name(dep) for dep in deps] |
| 87 | + |
| 88 | +def _npm_link_name(pkg_name): |
| 89 | + return "local_%s" % pkg_name.replace("@", "_").replace("/", "_") |
| 90 | + |
| 91 | +def _filtered_transitives_name(dep): |
| 92 | + if dep.startswith(":"): |
| 93 | + return "%s_filtered" % dep[1:] |
| 94 | + else: |
| 95 | + label = Label(dep) |
| 96 | + return "%s_filtered" % label.package.replace("@", "_").replace("/", "_") |
| 97 | + |
| 98 | +def _filter_transitive_angular_deps_impl(ctx): |
| 99 | + paths = ["external/aio_npm/node_modules/%s" % pkg for pkg in ctx.attr.angular_packages] |
| 100 | + |
| 101 | + filtered_deps = [] |
| 102 | + |
| 103 | + # Note: to_list() is expensive; we need to invoke it here to get the path |
| 104 | + # of each transitive dependency to check if it's an angular npm package. |
| 105 | + for file in ctx.attr.target[DefaultInfo].default_runfiles.files.to_list(): |
| 106 | + if not any([file.path.startswith(path) for path in paths]): |
| 107 | + filtered_deps.append(file) |
| 108 | + |
| 109 | + filtered_depset = depset(filtered_deps) |
| 110 | + providers = [ |
| 111 | + DefaultInfo( |
| 112 | + files = filtered_depset, |
| 113 | + ), |
| 114 | + ] |
| 115 | + |
| 116 | + if LinkerPackageMappingInfo in ctx.attr.target: |
| 117 | + providers.append(ctx.attr.target[LinkerPackageMappingInfo]) |
| 118 | + if LinkablePackageInfo in ctx.attr.target: |
| 119 | + providers.append(ctx.attr.target[LinkablePackageInfo]) |
| 120 | + |
| 121 | + return providers |
| 122 | + |
| 123 | +filter_transitive_angular_deps = rule( |
| 124 | + doc = "Filter out transitive angular dependencies from a target", |
| 125 | + implementation = _filter_transitive_angular_deps_impl, |
| 126 | + attrs = { |
| 127 | + "target": attr.label(mandatory = True, doc = "Target to filter"), |
| 128 | + "angular_packages": attr.string_list(default = [], doc = "Angular packages to filter"), |
| 129 | + }, |
| 130 | +) |
0 commit comments