Skip to content

Commit 868fd12

Browse files
committed
Make lower param of clamp required. [closes lodash#2949]
1 parent c5c0ff7 commit 868fd12

File tree

2 files changed

+10
-20
lines changed

2 files changed

+10
-20
lines changed

.internal/baseClamp.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,14 @@
33
*
44
* @private
55
* @param {number} number The number to clamp.
6-
* @param {number} [lower] The lower bound.
6+
* @param {number} lower The lower bound.
77
* @param {number} upper The upper bound.
88
* @returns {number} Returns the clamped number.
99
*/
1010
function baseClamp(number, lower, upper) {
1111
if (number === number) {
12-
if (upper !== undefined) {
13-
number = number <= upper ? number : upper;
14-
}
15-
if (lower !== undefined) {
16-
number = number >= lower ? number : lower;
17-
}
12+
number = number <= upper ? number : upper;
13+
number = number >= lower ? number : lower;
1814
}
1915
return number;
2016
}

clamp.js

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import toNumber from './toNumber.js';
77
* @since 4.0.0
88
* @category Number
99
* @param {number} number The number to clamp.
10-
* @param {number} [lower] The lower bound.
10+
* @param {number} lower The lower bound.
1111
* @param {number} upper The upper bound.
1212
* @returns {number} Returns the clamped number.
1313
* @example
@@ -19,18 +19,12 @@ import toNumber from './toNumber.js';
1919
* // => 5
2020
*/
2121
function clamp(number, lower, upper) {
22-
if (upper === undefined) {
23-
upper = lower;
24-
lower = undefined;
25-
}
26-
if (upper !== undefined) {
27-
upper = toNumber(upper);
28-
upper = upper === upper ? upper : 0;
29-
}
30-
if (lower !== undefined) {
31-
lower = toNumber(lower);
32-
lower = lower === lower ? lower : 0;
33-
}
22+
lower = toNumber(lower);
23+
lower = lower === lower ? lower : 0;
24+
25+
upper = toNumber(upper);
26+
upper = upper === upper ? upper : 0;
27+
3428
return baseClamp(toNumber(number), lower, upper);
3529
}
3630

0 commit comments

Comments
 (0)