Skip to content

Commit 2ded0e7

Browse files
committed
fix: release workflow race condition
1 parent 756db57 commit 2ded0e7

1 file changed

Lines changed: 18 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,24 @@ permissions:
99
contents: write
1010

1111
jobs:
12+
# ── Stage 1: create the GitHub Release once ──────────────────────────────
13+
create-release:
14+
name: Create GitHub Release
15+
runs-on: ubuntu-latest
16+
outputs:
17+
upload_url: ${{ steps.create.outputs.upload_url }}
18+
steps:
19+
- name: Create release
20+
id: create
21+
uses: softprops/action-gh-release@v2
22+
with:
23+
generate_release_notes: true
24+
draft: false
25+
26+
# ── Stage 2: build each platform and upload its asset ────────────────────
1227
build:
1328
name: Build ${{ matrix.suffix }}
29+
needs: create-release
1430
runs-on: ubuntu-latest
1531
strategy:
1632
matrix:
@@ -48,10 +64,9 @@ jobs:
4864
CGO_ENABLED: "0"
4965
run: |
5066
VERSION="${GITHUB_REF_NAME}"
51-
BINARY="termf1${{ matrix.ext }}"
5267
go build \
5368
-ldflags="-s -w -X main.version=${VERSION}" \
54-
-o "${BINARY}" .
69+
-o "termf1${{ matrix.ext }}" .
5570
5671
- name: Package archive
5772
id: archive
@@ -67,8 +82,7 @@ jobs:
6782
echo "asset=${ARCHIVE}.tar.gz" >> "$GITHUB_OUTPUT"
6883
fi
6984
70-
- name: Upload to release
85+
- name: Upload asset
7186
uses: softprops/action-gh-release@v2
7287
with:
7388
files: ${{ steps.archive.outputs.asset }}
74-
generate_release_notes: true

0 commit comments

Comments
 (0)