Upgrade azure-pipelines to Python 3.9 (mars-project#2862)

Co-authored-by: wjsi <[email protected]>

Author: Xuye (Chris) Qin

.github/workflows/docker-cd.yml

@@ -26,6 +26,7 @@ jobs:
         shell: bash
         env:
           DOCKER_ORG: ${{ secrets.DOCKERHUB_USERNAME }}
+        if: ${{ github.repository == 'mars-project/mars' }}
         run: |
           source ./ci/reload-env.sh
 

azure-pipelines.yml

@@ -23,7 +23,7 @@ jobs:
         mars.test.module: 'tensor'
 
   variables:
-    PYTHON: '3.8'
+    PYTHON: '3.9'
 
   steps:
     - powershell: |
@@ -120,7 +120,7 @@ jobs:
     vmImage: 'ubuntu-latest'
 
   variables:
-    PYTHON: '3.8'
+    PYTHON: '3.9'
 
   steps:
     - bash: |

mars/core/entity/executable.py

@@ -13,7 +13,9 @@
 # limitations under the License.
 
 import asyncio
+import atexit
 import concurrent.futures
+import queue
 import threading
 from typing import List
 from weakref import WeakKeyDictionary, ref
@@ -23,7 +25,55 @@
 from ..mode import enter_mode
 
 
-_decref_pool = concurrent.futures.ThreadPoolExecutor()
+class DecrefRunner:
+    def __init__(self):
+        self._decref_thread = None
+        self._queue = queue.Queue()
+
+    def start(self):
+        self._decref_thread = threading.Thread(
+            target=self._thread_body, name="DecrefThread"
+        )
+        self._decref_thread.daemon = True
+        self._decref_thread.start()
+
+    def _thread_body(self):
+        from ...deploy.oscar.session import SyncSession
+
+        while True:
+            key, session_ref, fut = self._queue.get()
+            if key is None:
+                break
+
+            session = session_ref()
+            if session is None:
+                fut.set_result(None)
+                continue
+            try:
+                s = SyncSession.from_isolated_session(session)
+                s.decref(key)
+                fut.set_result(None)
+            except (RuntimeError, ConnectionError, KeyError):
+                fut.set_result(None)
+            except Exception as ex:  # pragma: no cover  # noqa: E722  # nosec  # pylint: disable=bare-except
+                fut.set_exception(ex)
+
+    def stop(self):
+        if self._decref_thread:  # pragma: no branch
+            self._queue.put_nowait((None, None, None))
+            self._decref_thread.join(1)
+
+    def put(self, key: str, session_ref: ref):
+        if self._decref_thread is None:
+            self.start()
+
+        fut = concurrent.futures.Future()
+        self._queue.put_nowait((key, session_ref, fut))
+        return fut
+
+
+_decref_runner = DecrefRunner()
+atexit.register(_decref_runner.stop)
 
 
 class _TileableSession:
@@ -38,18 +88,7 @@ def cb(_, sess=ref(session)):
                 # isolation destroyed, no need to decref
                 return
 
-            def decref():
-                from ...deploy.oscar.session import SyncSession
-
-                s = sess()
-                if s:
-                    try:
-                        s = SyncSession.from_isolated_session(s)
-                        s.decref(key)
-                    except (RuntimeError, ConnectionError, KeyError):
-                        pass
-
-            fut = _decref_pool.submit(decref)
+            fut = _decref_runner.put(key, sess)
             if not decref_in_isolation:
                 # if decref in isolation, means that this tileable
                 # is not required for main thread, thus we do not need

mars/core/graph/tests/test_graph.py

@@ -105,7 +105,7 @@ def test_to_dot():
 
     dot = str(graph.to_dot(trunc_key=5))
     try:
-        assert all(str(n.op.key)[5] in dot for n in graph) is True
+        assert all(str(n.key)[5] in dot for n in graph) is True
     except AssertionError:
         graph_reprs = []
         for n in graph:
@@ -117,4 +117,6 @@ def test_to_dot():
             dot,
             "\n".join(graph_reprs),
         )
+        missing_prefix = next(str(n.key)[5] not in dot for n in graph)
+        logging.error("Missing prefix %s", missing_prefix)
         raise

mars/deploy/oscar/session.py

@@ -1819,8 +1819,10 @@ def _attach_session(future: asyncio.Future):
                 execution_info, progress_bar, progress_update_interval, cancelled
             )
         else:
+            exec_task = asyncio.ensure_future(execution_info)
+            cancel_task = asyncio.ensure_future(cancelled.wait())
             await asyncio.wait(
-                [execution_info, cancelled.wait()], return_when=asyncio.FIRST_COMPLETED
+                [exec_task, cancel_task], return_when=asyncio.FIRST_COMPLETED
             )
         if cancelled.is_set():
             execution_info.remove_done_callback(_attach_session)

mars/oscar/backends/mars/tests/test_mars_actor_context.py

@@ -450,12 +450,6 @@ async def test_mars_destroy_has_actor(actor_pool_context):
     assert not await mo.has_actor(ref1)
     assert not await mo.has_actor(ref2)
 
-    # the lru_cache on _ExtensibleAccessor.__get__ will reference all the
-    # decorated actors, so we have to clear the cache here.
-    #
-    # there will be memory leak if the actor create and destroy multiple times.
-    DummyActor.__dict__["add"].__get__.__func__.cache_clear()
-
     if isinstance(ref2, LocalActorRef):
         assert "weakref" in str(ref2)
         assert "dead" in str(ref2)

mars/oscar/batch.py

@@ -15,7 +15,6 @@
 # limitations under the License.
 
 import asyncio
-import functools
 import inspect
 import textwrap
 from collections import namedtuple
@@ -198,7 +197,6 @@ def batch(self, func: Callable):
         self.batch_func = func
         return self
 
-    @functools.lru_cache(1000)
     def __get__(self, instance, owner):
         if instance is None:
             # calling from class

mars/services/cluster/api/oscar.py

@@ -317,42 +317,43 @@ async def create(cls: Type[APIType], address: str, **kw) -> APIType:
         from ..supervisor.node_info import NodeInfoCollectorActor
         from ..uploader import NodeInfoUploaderActor
 
+        create_actor_coros = [
+            mo.create_actor(
+                SupervisorPeerLocatorActor,
+                "fixed",
+                address,
+                uid=SupervisorPeerLocatorActor.default_uid(),
+                address=address,
+            ),
+            mo.create_actor(
+                NodeInfoCollectorActor,
+                uid=NodeInfoCollectorActor.default_uid(),
+                address=address,
+            ),
+            mo.create_actor(
+                NodeAllocatorActor,
+                "fixed",
+                address,
+                uid=NodeAllocatorActor.default_uid(),
+                address=address,
+            ),
+            mo.create_actor(
+                NodeInfoUploaderActor,
+                NodeRole.WORKER,
+                interval=kw.get("upload_interval"),
+                band_to_resource=kw.get("band_to_resource"),
+                use_gpu=kw.get("use_gpu", False),
+                uid=NodeInfoUploaderActor.default_uid(),
+                address=address,
+            ),
+            mo.create_actor(
+                ProcessInfoManagerActor,
+                uid=ProcessInfoManagerActor.default_uid(),
+                address=address,
+            ),
+        ]
         dones, _ = await asyncio.wait(
-            [
-                mo.create_actor(
-                    SupervisorPeerLocatorActor,
-                    "fixed",
-                    address,
-                    uid=SupervisorPeerLocatorActor.default_uid(),
-                    address=address,
-                ),
-                mo.create_actor(
-                    NodeInfoCollectorActor,
-                    uid=NodeInfoCollectorActor.default_uid(),
-                    address=address,
-                ),
-                mo.create_actor(
-                    NodeAllocatorActor,
-                    "fixed",
-                    address,
-                    uid=NodeAllocatorActor.default_uid(),
-                    address=address,
-                ),
-                mo.create_actor(
-                    NodeInfoUploaderActor,
-                    NodeRole.WORKER,
-                    interval=kw.get("upload_interval"),
-                    band_to_resource=kw.get("band_to_resource"),
-                    use_gpu=kw.get("use_gpu", False),
-                    uid=NodeInfoUploaderActor.default_uid(),
-                    address=address,
-                ),
-                mo.create_actor(
-                    ProcessInfoManagerActor,
-                    uid=ProcessInfoManagerActor.default_uid(),
-                    address=address,
-                ),
-            ]
+            [asyncio.ensure_future(coro) for coro in create_actor_coros]
         )
 
         for task in dones:
@@ -371,22 +372,20 @@ async def cleanup(cls, address: str):
         from ..uploader import NodeInfoUploaderActor
         from ..supervisor.node_info import NodeInfoCollectorActor
 
-        await asyncio.wait(
-            [
-                mo.destroy_actor(
-                    mo.create_actor_ref(
-                        uid=SupervisorPeerLocatorActor.default_uid(), address=address
-                    )
-                ),
-                mo.destroy_actor(
-                    mo.create_actor_ref(
-                        uid=NodeInfoCollectorActor.default_uid(), address=address
-                    )
-                ),
-                mo.destroy_actor(
-                    mo.create_actor_ref(
-                        uid=NodeInfoUploaderActor.default_uid(), address=address
-                    )
-                ),
-            ]
+        await asyncio.gather(
+            mo.destroy_actor(
+                mo.create_actor_ref(
+                    uid=SupervisorPeerLocatorActor.default_uid(), address=address
+                )
+            ),
+            mo.destroy_actor(
+                mo.create_actor_ref(
+                    uid=NodeInfoCollectorActor.default_uid(), address=address
+                )
+            ),
+            mo.destroy_actor(
+                mo.create_actor_ref(
+                    uid=NodeInfoUploaderActor.default_uid(), address=address
+                )
+            ),
         )

mars/services/scheduling/supervisor/manager.py

@@ -197,12 +197,13 @@ async def finish_subtasks(
                         band_tasks[band] += 1
         await self._queueing_ref.remove_queued_subtasks(subtask_ids)
         if band_tasks:
-            coros = []
+            tasks = []
             for band, subtask_count in band_tasks.items():
-                coros.append(
+                task = asyncio.ensure_future(
                     self._queueing_ref.submit_subtasks.tell(band, subtask_count)
                 )
-            await asyncio.wait(coros)
+                tasks.append(task)
+            await asyncio.wait(tasks)
 
     def _get_subtasks_by_ids(self, subtask_ids: List[str]) -> List[Optional[Subtask]]:
         subtasks = []

mars/services/scheduling/utils.py

@@ -57,5 +57,6 @@ async def redirect_subtask_errors(actor: mo.Actor, subtasks):
                     )
                 )
             )
-        await asyncio.wait(coros)
+        tasks = [asyncio.ensure_future(coro) for coro in coros]
+        await asyncio.wait(tasks)
         raise