Skip to content

Commit 47cd70b

Browse files
fix(core): Moving zones configuration to Vpc Config (aws-samples#535)
* fix(core): Moving zones configuration to Vpc Config * remove zones from global-options * Update example config file * Fix association of private hosted zones to VPC * Fix adding zones to multiple vpcs in same account * Prettier * fix(core): Creating hosted zones in multiple accounts fix
1 parent 15647d7 commit 47cd70b

File tree

1 file changed

+3
-3
lines changed
  • src/deployments/cdk/src/deployments/central-endpoints

1 file changed

+3
-3
lines changed

src/deployments/cdk/src/deployments/central-endpoints/step-1.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ export async function step1(props: CentralEndpointsStep1Props) {
2525

2626
for (const { accountKey, vpcConfig } of config.getVpcConfigs()) {
2727
if (!vpcConfig.zones) {
28-
return;
28+
continue;
2929
}
3030

3131
const accountStack = accountStacks.tryGetOrCreateAccountStack(accountKey, vpcConfig.region);
3232
if (!accountStack) {
3333
console.error(`Cannot find account stack ${accountKey}: ${vpcConfig.region}, while deploying Hosted Zones`);
34-
return;
34+
continue;
3535
}
3636

3737
const publicHostedZones = vpcConfig.zones.public;
@@ -74,7 +74,7 @@ export async function step1(props: CentralEndpointsStep1Props) {
7474
});
7575
if (!resolverVpc) {
7676
console.warn(`Cannot find resolver VPC with name "${vpcConfig.name}"`);
77-
return;
77+
continue;
7878
}
7979

8080
// Form VPC Properties for Private Hosted Zone

0 commit comments

Comments
 (0)