Skip to content

[feature] get rid of appassembler-maven-plugin #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dizzzz wants to merge 8 commits into
base: develop
Choose a base branch
from
+359 −246
Draft

[feature] get rid of appassembler-maven-plugin #5951

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa0b2c7
[ignore] prepare with original scripts
dizzzz Nov 30, 2025
0ba6330
[feature] get rid of appassembler plugin
dizzzz Nov 30, 2025
93d3036
[ci] use correct configuration
dizzzz Nov 30, 2025
e1c762d
[ignore] address code quality issues in shell script
dizzzz Nov 30, 2025
4677bca
[ignore] address code quality issues in batch script
dizzzz Nov 30, 2025
ae19eb7
[ignore] address code quality issues in shell script
dizzzz Nov 30, 2025
5ad6dec
[ignore] cleanup code
dizzzz Dec 3, 2025
58f72fc
[ignore] make sure java can be started. "sh" is rather limited compa…
dizzzz Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[ignore] address code quality issues in shell script
  • Loading branch information
@dizzzz
dizzzz committed Nov 30, 2025
commit ae19eb746dd9b7c3fcaa250b4f811f5f45696bc9
2 changes: 1 addition & 1 deletion exist-distribution/src/main/templates/template.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
darwin=false;
case "$(uname)" in
CYGWIN*) cygwin=true ;;
Darwin*) darwin=true

Check warning on line 50 in exist-distribution/src/main/templates/template.sh

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

exist-distribution/src/main/templates/template.sh#L50 

darwin appears unused. Verify use (or export if used externally).
if [ -z "$JAVA_VERSION" ] ; then
JAVA_VERSION="CurrentJDK"
else
Expand Down Expand Up @@ -89,7 +89,7 @@
if command -v java >/dev/null 2>&1; then
JAVACMD=$(command -v java)
else
JAVACMD=`which java`
JAVACMD=$(which java)
fi
fi
fi
Expand Down Expand Up @@ -120,7 +120,7 @@
[ -n "$REPO" ] && REPO=$(cygpath --path --windows "$REPO")
fi

exec "$JAVACMD" $JAVA_OPTS -Xms128m -XX:+UseNUMA -XX:+UseZGC -XX:+UseStringDeduplication \

Check warning on line 123 in exist-distribution/src/main/templates/template.sh

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

exist-distribution/src/main/templates/template.sh#L123 

Double quote to prevent globbing and word splitting.
-Dfile.encoding=UTF-8 -Dlog4j.configurationFile="$BASEDIR"/etc/log4j2.xml \
-Dexist.home="$BASEDIR" -Dexist.configurationFile="$BASEDIR"/etc/conf.xml \
-Djetty.home="$BASEDIR" -Dexist.jetty.config="$BASEDIR"/etc/jetty/standard.enabled-jetty-configs \
Expand Down
Loading