Skip to content

Commit e3d4413

Browse files
Lekensteynalagoutte
authored andcommitted
QUIC: fix Malformed Packet exception with small transport parameters
Since draft 27 the minimum transport parameter size can be smaller than 4 due to variable-length encoding. With ngtcp2-29-dsb.pcapng, the active_connection_id_limit at the end covers only three bytes for example. Even though the correct length is normally set later, the early attempt to read four bytes resulted in an Malformed Packet exception. Change-Id: I9ec6ec6c66ce7a993f2fcfdc987e35966dc809ac Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/37483 Petri-Dish: Peter Wu <[email protected]> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <[email protected]>
1 parent 933067a commit e3d4413

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

epan/dissectors/packet-tls-utils.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6867,7 +6867,7 @@ ssl_dissect_hnd_hello_ext_quic_transport_parameters(ssl_common_dissect_t *hf, tv
68676867
guint64 value;
68686868
guint32 len = 0;
68696869

6870-
parameter_tree = proto_tree_add_subtree(tree, tvb, offset, 4, hf->ett.hs_ext_quictp_parameter,
6870+
parameter_tree = proto_tree_add_subtree(tree, tvb, offset, 2, hf->ett.hs_ext_quictp_parameter,
68716871
NULL, "Parameter");
68726872
/* TransportParameter ID and Length. */
68736873
if (use_varint_encoding) {

0 commit comments

Comments
 (0)