-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
Labels
api: spannerIssues related to the googleapis/langchain-google-spanner-python API.Issues related to the googleapis/langchain-google-spanner-python API.
Description
I believe there is a step missing from the vector store notebook "Add documents" section. It never actually adds the documents to the vector store...
import uuid
from langchain_community.document_loaders import HNLoader
loader = HNLoader("https://news.ycombinator.com/item?id=34817881")
documents = loader.load()
ids = [str(uuid.uuid4()) for _ in range(len(documents))]Code affected.
langchain-google-spanner-python/docs/vector_store.ipynb
Lines 285 to 292 in 59ed711
| "import uuid\n", | |
| "\n", | |
| "from langchain_community.document_loaders import HNLoader\n", | |
| "\n", | |
| "loader = HNLoader(\"https://news.ycombinator.com/item?id=34817881\")\n", | |
| "\n", | |
| "documents = loader.load()\n", | |
| "ids = [str(uuid.uuid4()) for _ in range(len(documents))]" |
There are also 🔐 emojis in the section which have no reason to be there...
Metadata
Metadata
Assignees
Labels
api: spannerIssues related to the googleapis/langchain-google-spanner-python API.Issues related to the googleapis/langchain-google-spanner-python API.