Skip to content

Commit b08cf0a

Browse files
committed
fixed qmaster_spooling and resource_reservation test for 9.1.0 (host slots too low)
1 parent f202240 commit b08cf0a

File tree

2 files changed

+23
-13
lines changed
  • src/checktree/system_tests

2 files changed

+23
-13
lines changed

src/checktree/system_tests/qmaster/spooling/check.exp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,9 @@ proc qmaster_spooling_setup {} {
7777
} else {
7878
set qmaster_spooling_dateformat "%m/%d/%Y %H:%M:%S"
7979
}
80+
81+
# beginning with 9.1.0 we need to setup host slots for binding
82+
setup_host_slots_for_binding
8083
}
8184

8285
proc qmaster_spooling_cleanup {} {
@@ -89,8 +92,11 @@ proc qmaster_spooling_cleanup {} {
8992
del_rqs $elem
9093
}
9194
}
95+
9296
delete_all_ars
9397

98+
cleanup_host_slots_for_binding
99+
94100
unset -nocomplain qmaster_spooling_dateformat
95101
}
96102

src/checktree/system_tests/scheduler/resource_reservation/check.exp

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,9 @@ lappend check_functions "resource_reservation_basic"
6666
# -------- local test procedures: initialization ------------------------------
6767

6868
proc resource_reservation_setup {} {
69-
global rr_queue_name rr_cal_queue_name rr_h_vmem_complex
70-
global rr_host
7169
global ts_config
72-
global resource_reservation_complex_backup
70+
global rr_queue_name rr_cal_queue_name rr_h_vmem_complex rr_host
71+
global resource_reservation_complex_backup resource_reservation_host_backup
7372

7473
ts_log_fine "resource_reservation_setup"
7574

@@ -119,22 +118,25 @@ proc resource_reservation_setup {} {
119118
# enable / disable queues needed for the test
120119
disable_queue "all.q"
121120

122-
#-----
121+
# set host complex_values
122+
# for 9.1.0 and higher we need to set slots
123+
setup_host_slots_for_binding
123124

124125
# set global variable
125126
set my_host_config(complex_values) "license=10,license2=10"
126127
set_exechost my_host_config "global"
127128

128129
# set host variable
129-
set my_host_config(complex_values) "h_vmem=20G"
130-
set_exechost my_host_config $rr_host
130+
get_exechost eh_backup $rr_host
131+
set resource_reservation_host_backup($rr_host) $eh_backup(complex_values)
132+
add_or_replace_array_param eh eh_backup "complex_values" "h_vmem" "20G"
133+
set_exechost eh $rr_host
131134
}
132135

133136
proc resource_reservation_level_setup {} {
134-
global rr_queue_name rr_cal_queue_name rr_h_vmem_complex
135-
global rr_host
136137
global ts_config
137138
global CHECK_ACT_LEVEL
139+
global rr_queue_name rr_cal_queue_name rr_h_vmem_complex rr_host
138140

139141
switch -- $CHECK_ACT_LEVEL {
140142
2 {
@@ -261,10 +263,10 @@ proc resource_reservation_level_setup {} {
261263
}
262264

263265
proc resource_reservation_cleanup { } {
264-
global rr_h_vmem_complex
265266
global ts_config
267+
global rr_h_vmem_complex
266268
global rr_host
267-
global resource_reservation_complex_backup
269+
global resource_reservation_complex_backup resource_reservation_host_backup
268270

269271
# reset the scheduler configuration
270272
reset_schedd_config
@@ -274,17 +276,19 @@ proc resource_reservation_cleanup { } {
274276
set_exechost my_host_config "global"
275277

276278
# set host variable
277-
set my_host_config(complex_values) "NONE"
278-
set_exechost my_host_config $rr_host
279+
host_restore_complex_values resource_reservation_host_backup
280+
281+
cleanup_host_slots_for_binding
279282

280283
# remove complex attributes
281284
reset_complex resource_reservation_complex_backup
282285
unset resource_reservation_complex_backup
283286

284287
# enable queues
285-
enable_queue "all.q"
288+
enable_queue "all.q"
286289

287290
unset -nocomplain rr_h_vmem_complex rr_host global resource_reservation_complex_backup
291+
unset -nocomplain resource_reservation_host_backup
288292
}
289293

290294
proc resource_reservation_level_cleanup {} {

0 commit comments

Comments
 (0)