Use a file for generic preview cache

Author: udbhav-s

embeds/generic-preview.ts

@@ -26,8 +26,8 @@ export class GenericPreviewEmbed implements EmbedSource {
     const loadPreview = async () => {
       let metadata;
 
-      if (settings.useCacheForGenericLinks && link in settings.genericPreviewCache) {
-        metadata = settings.genericPreviewCache[link];
+      if (settings.useCacheForGenericLinks && link in plugin.genericPreviewCache) {
+        metadata = plugin.genericPreviewCache[link];
       } else {
         const res = await requestUrl({ url: link });
         metadata = await getPreviewFromContent({

main.ts

@@ -15,7 +15,7 @@ import {
   YouTubeEmbed,
   GenericPreviewEmbed,
 } from "./embeds";
-import { debounce, Debouncer, MarkdownView, Plugin } from "obsidian";
+import { debounce, Debouncer, MarkdownView, Plugin, TFile } from "obsidian";
 import { DEFAULT_SETTINGS, GenericPreviewMetadata, PluginSettings } from "./settings";
 import { SimpleEmbedPluginSettingTab } from "./settings-tab";
 import { buildSimpleEmbedsViewPlugin } from "./view-plugin";
@@ -40,6 +40,10 @@ export default class SimpleEmbedsPlugin extends Plugin {
   processedMarkdown: Debouncer<[]>;
   currentTheme: "dark" | "light";
   genericPreviewEmbed = new GenericPreviewEmbed();
+  genericPreviewCache = {} as {
+    [url: string]: GenericPreviewMetadata;
+  };
+  genericPreviewCacheFile = "genericPreviewCache.json";
 
   async onload() {
     console.log(`Loading ${this.manifest.name} v${this.manifest.version}`);
@@ -81,6 +85,20 @@ export default class SimpleEmbedsPlugin extends Plugin {
         }
       }),
     );
+
+    // Load file for generic preview cache
+    if (!this.app.vault.adapter.exists(this.genericPreviewCacheFile)) {
+      await this.app.vault.create("genericPreviewCache.json", "{}");
+    }
+    try {
+      const contents = JSON.parse(
+        await this.app.vault.adapter.read(this.genericPreviewCacheFile)
+      );
+      this.genericPreviewCache = contents;
+    } catch (e) {
+      console.error("Error reading generic preview cache file");
+      console.error(e);
+    }
   }
 
   onunload() {
@@ -103,8 +121,13 @@ export default class SimpleEmbedsPlugin extends Plugin {
   }
 
   async saveGenericPreviewCache(link: string, metadata: GenericPreviewMetadata) {
-    this.settings.genericPreviewCache[link] = metadata;
-    await this.saveData(this.settings);
+    if (this.genericPreviewCacheFile) {
+      this.genericPreviewCache[link] = metadata;
+      await this.app.vault.adapter.write(
+        this.genericPreviewCacheFile,
+        JSON.stringify(this.genericPreviewCache)
+      );
+    }
   }
 
   private _getCurrentTheme(): "dark" | "light" {

settings-tab.ts

@@ -70,7 +70,9 @@ export class SimpleEmbedPluginSettingTab extends PluginSettingTab {
         button
           .setButtonText("Clear")
           .onClick(async () => {
-            await this.saveSettings({ genericPreviewCache: {} });
+            await this.app.vault.adapter.write(this.plugin.genericPreviewCacheFile, "{}");
+            this.plugin.genericPreviewCache = {};
+            await this.plugin.saveSettings({});
           });
       });
 

settings.ts

@@ -43,9 +43,9 @@ export interface GenericPreviewMetadata {
 
 export interface GenericPreviewSettings {
   useCacheForGenericLinks: boolean;
-  genericPreviewCache: {
-    [url: string]: GenericPreviewMetadata;
-  };
+  // genericPreviewCache: {
+  //   [url: string]: GenericPreviewMetadata;
+  // };
 }
 
 export interface PluginSettings
@@ -71,9 +71,8 @@ export const DEFAULT_SETTINGS: PluginSettings = {
   replaceVimeoLinks: true,
   replaceYouTubeLinks: true,
 
-  replaceGenericLinks: true,
+  replaceGenericLinks: false,
   useCacheForGenericLinks: true,
-  genericPreviewCache: {},
 
   twitterTheme: "auto",