fix saving cache data

Author: udbhav-s

embeds/generic-preview.ts

@@ -21,13 +21,13 @@ export class GenericPreviewEmbed implements EmbedSource {
     const preview = document.createElement("a");
     preview.setAttr("href", link);
     preview.classList.add("preview");
-    preview.textContent = "Loading embed...";
+    preview.textContent = "Loading preview...";
 
     const loadPreview = async () => {
       let metadata;
 
-      if (settings.useCacheForGenericLinks && link in plugin.linkPreviewCache) {
-        metadata = plugin.linkPreviewCache[link];
+      if (settings.useCacheForGenericLinks && link in settings.genericPreviewCache) {
+        metadata = settings.genericPreviewCache[link];
       } else {
         const res = await requestUrl({ url: link });
         metadata = await getPreviewFromContent({
@@ -37,7 +37,7 @@ export class GenericPreviewEmbed implements EmbedSource {
         });
 
         if (settings.useCacheForGenericLinks && "title" in metadata) {
-          plugin.linkPreviewCache[link] = metadata;
+          plugin.saveGenericPreviewCache(link, metadata);
         }
       }
 

main.ts

@@ -39,16 +39,12 @@ export default class SimpleEmbedsPlugin extends Plugin {
   ];
   processedMarkdown: Debouncer<[]>;
   currentTheme: "dark" | "light";
-
   genericPreviewEmbed = new GenericPreviewEmbed();
-  // use a separate property to save to cache during session
-  // saveSettings triggers reload and results in a loop
-  linkPreviewCache: { [url: string]: GenericPreviewMetadata };
 
   async onload() {
     console.log(`Loading ${this.manifest.name} v${this.manifest.version}`);
     await this.loadSettings();
-    this.linkPreviewCache = this.settings.genericPreviewCache;
+    console.log(this.settings);
     this.addSettingTab(new SimpleEmbedPluginSettingTab(this.app, this));
 
     this.currentTheme = this._getCurrentTheme();
@@ -89,12 +85,6 @@ export default class SimpleEmbedsPlugin extends Plugin {
   }
 
   onunload() {
-    // save the cache before unloading
-    console.log("Saving link preview cache to settings");
-    this.saveSettings({
-      genericPreviewCache: this.linkPreviewCache,
-    });
-
     console.log(`Unloading ${this.manifest.name}`);
     this.processedMarkdown = null;
   }
@@ -113,6 +103,11 @@ export default class SimpleEmbedsPlugin extends Plugin {
     });
   }
 
+  async saveGenericPreviewCache(link: string, metadata: GenericPreviewMetadata) {
+    this.settings.genericPreviewCache[link] = metadata;
+    await this.saveData(this.settings);
+  }
+
   private _getCurrentTheme(): "dark" | "light" {
     return document.body.classList.contains("theme-dark") ? "dark" : "light";
   }

settings-tab.ts

@@ -66,7 +66,7 @@ export class SimpleEmbedPluginSettingTab extends PluginSettingTab {
       });
     new Setting(containerEl)
       .setName("Clear link preview metadata cache")
-      .addButton(async (button) => {
+      .addButton((button) => {
         button
           .setButtonText("Clear")
           .onClick(async () => {