Minor code adjustments to CommonUtils to use String.isEmpty()

Author: SavvasMisaghMoayyed

cas-client-core/src/main/java/org/jasig/cas/client/util/CommonUtils.java

@@ -135,7 +135,7 @@ public static void assertFalse(final boolean cond, final String message) {
      * @return true if its null or length of 0, false otherwise.
      */
     public static boolean isEmpty(final String string) {
-        return string == null || string.length() == 0;
+        return string == null || string.isEmpty();
     }
 
     /**
@@ -157,7 +157,7 @@ public static boolean isNotEmpty(final String string) {
      * @return true if its blank, false otherwise.
      */
     public static boolean isBlank(final String string) {
-        return isEmpty(string) || string.trim().length() == 0;
+        return isEmpty(string) || string.trim().isEmpty();
     }
 
     /**
@@ -193,7 +193,7 @@ public static String constructRedirectUrl(final String casServerLoginUrl, final
      * @param value the value to encode.
      * @return the encoded value.
      */
-    public static String urlEncode(String value) {
+    public static String urlEncode(final String value) {
         try {
             return URLEncoder.encode(value, "UTF-8");
         } catch (final UnsupportedEncodingException e) {
@@ -228,7 +228,7 @@ public static void readAndRespondToProxyReceptorRequest(final HttpServletRequest
     protected static String findMatchingServerName(final HttpServletRequest request, final String serverName) {
         final String[] serverNames = serverName.split(" ");
 
-        if (serverNames == null || serverNames.length == 0 || serverNames.length == 1) {
+        if (serverNames.length == 0 || serverNames.length == 1) {
             return serverName;
         }
 
@@ -323,7 +323,7 @@ public static String constructServiceUrl(final HttpServletRequest request, final
         final URIBuilder originalRequestUrl = new URIBuilder(request.getRequestURL().toString(), encode);
         originalRequestUrl.setParameters(request.getQueryString());
 
-        URIBuilder builder = null;
+        final URIBuilder builder;
 
         boolean containsScheme = true;
         if (!serverName.startsWith("https://") && !serverName.startsWith("http://")) {