Handle date equality when checking for saml assertion validity

Author: SavvasMisaghMoayyed

cas-client-core/src/main/java/org/jasig/cas/client/validation/AssertionImpl.java

@@ -133,6 +133,7 @@ public boolean isValid() {
         }
 
         final Date now = new Date();
-        return this.validFromDate.before(now) && (this.validUntilDate == null || this.validUntilDate.after(now));
+        return (this.validFromDate.before(now) || this.validFromDate.equals(now)) 
+                && (this.validUntilDate == null || this.validUntilDate.after(now) || this.validUntilDate.equals(now));
     }
 }

cas-client-core/src/test/java/org/jasig/cas/client/validation/AssertionImplTests.java

@@ -18,6 +18,7 @@
  */
 package org.jasig.cas.client.validation;
 
+import java.util.Date;
 import java.util.HashMap;
 import java.util.Map;
 import junit.framework.TestCase;
@@ -50,7 +51,7 @@ public void testPrincipalConstructor() {
     }
 
     public void testAssertionValidity() throws Exception {
-        final Assertion assertion = new AssertionImpl(CONST_PRINCIPAL, CONST_ATTRIBUTES);
+        final Assertion assertion = new AssertionImpl(CONST_PRINCIPAL, new Date(), new Date(), new Date(), CONST_ATTRIBUTES);
         assertTrue(assertion.isValid());
     }