Skip to content

Commit 64ec80c

Browse files
committed
Updates README and documentation
1 parent 22e00a6 commit 64ec80c

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ Note that changes to the major version (i.e. the first number) represent possibl
134134
may require modifications in your code to migrate. Changes to the minor version (i.e. the second number)
135135
should represent non-breaking changes. The third number represents any very minor bugfix patches.
136136

137-
* **2.0.0 (in progress)**: Adds support for authentication via the AppRole auth backend.
137+
* **2.0.0 (in progress)**: Adds support for authentication via the AppRole auth backend. Adds support for
138+
renewing secret leases.
138139
* **1.2.0**: This is a substantial release, with numerous additions. It's a minor version number only because there
139140
should be no breaking changes. The changes include the following:
140141
* Switches from Vault 0.5.x to 0.6.x for automated tests.

src/main/java/com/bettercloud/vault/api/Leases.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,14 @@ public VaultResponse revokeForce(final String prefix) throws VaultException {
202202
* @throws VaultException The response information returned from Vault
203203
*/
204204
public VaultResponse renew(final String leaseId, final long increment) throws VaultException {
205+
206+
// TODO: Unfortunately, there is not currently a way to cover this in the integration test suite.
207+
// The "generic" backend does not support support lease renewal. The only other backend
208+
// currently available to the integration test suite is the "pki" backend, which does
209+
// support renewal of credentials, etc. But lease renewal in this context is talking about
210+
// secrets. Perhaps revisit this at some point in the future if other backends are available
211+
// to the integration test suite (e.g. if we eventually start using Docker).
212+
205213
int retryCount = 0;
206214
while (true) {
207215
try {

0 commit comments

Comments
 (0)