Skip to content

Conversation

@Sunxperous
Copy link
Contributor

No description provided.

@yangshun
Copy link
Member

yangshun commented Dec 6, 2016

Finally.... thanks @quanyang too.

@yangshun yangshun merged commit f407485 into nusmodifications:master Dec 6, 2016
var config = {
// Your NUSSTU ID, such as a0012345
student_id: prompt('Your NUSSTU ID, such as a0012345'),
student_id: STUDENT_ID,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh extra space

// CONFIGURE THE RELEVANT PROPERTIES IN THE CONFIG OBJECT
// ***********************************************************

if (typeof STUDENT_ID == 'undefined') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

declare STUDENT_ID before this line

Copy link
Member

@yangshun yangshun Dec 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!STUDENT_ID) will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants