Update CS3217 script for 2018 #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Member
|
I'm happy and sad at the same time that the scripts still need to be maintained. Thanks! |
yangshun
approved these changes
Apr 23, 2018
Collaborator
Author
|
Wow didn't get flamed for the great big hack |
Member
|
Didn't really review because I can't test it and if it works, it works. I wouldn't import a time library just for this anyway. The way you did it was fine in the context of a one-off script. #movefast |
yangshun
reviewed
Apr 23, 2018
| day: 'SUNDAY', | ||
| start_time: '1400', | ||
| end_time: '1600' | ||
| start_time: times['start_time'], |
| start_time: '1400', | ||
| end_time: '1600' | ||
| start_time: times['start_time'], | ||
| end_time: times['end_time'] |
| if (week == 7) continue; | ||
| // Grading claims | ||
| for (var ps = 0; ps < 5; ps++) { | ||
| var ps_hours = ps_students[ps] * ps_rates[ps]; |
Member
There was a problem hiding this comment.
vars are function scope, so avoid using vars in a for-loop. Use let or wrap the body in an IIFE.
Collaborator
Author
|
🌚 |
taneliang
reviewed
Apr 24, 2018
| start_time: '1200', | ||
| end_time: '1400' | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
Tsk @louietyj never configure editor to trim spaces on save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.