-
Notifications
You must be signed in to change notification settings - Fork 4
Comparing changes
Open a pull request
base repository: mcintyre94/ragelib
base: master
head repository: perf101/ragelib
compare: master
- 20 commits
- 14 files changed
- 8 contributors
Commits on Mar 25, 2018
-
- Change timeout to 60s (5 mins is too long) - Catch exceptions when fetching the image and skip (better to get all images except 1 than crash) Signed-off-by: Callum McIntyre <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for efa41ce - Browse repository at this point
Copy the full SHA efa41ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for b97d492 - Browse repository at this point
Copy the full SHA b97d492View commit details
Commits on May 9, 2018
-
Merge pull request #2 from perf101/add-context
Add the context to data
Configuration menu - View commit details
-
Copy full SHA for e8c7dd0 - Browse repository at this point
Copy the full SHA e8c7dd0View commit details
Commits on Sep 30, 2022
-
Context includes useful data about how the test ran - the soms, machines used, VMs used, and other test parameters. This is useful for differentiating between tests with the same/similar names, and without it we need to click through to the RAGE graph to determine how tests differed. ragelib now passes context of each row for consumers to use however suits them bet. Signed-off-by: Callum McIntyre <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5f0bf11 - Browse repository at this point
Copy the full SHA 5f0bf11View commit details -
Added handling of alert box popup when rage tries to graph with a lar…
…ge number of points
Configuration menu - View commit details
-
Copy full SHA for 1f9d621 - Browse repository at this point
Copy the full SHA 1f9d621View commit details
Commits on Oct 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 69db96c - Browse repository at this point
Copy the full SHA 69db96cView commit details
Commits on Oct 26, 2022
-
Merge pull request #3 from PCookies/private/patrickcoo/CP-38420
Private/patrickcoo/cp 38420
Configuration menu - View commit details
-
Copy full SHA for 3512ac9 - Browse repository at this point
Copy the full SHA 3512ac9View commit details
Commits on Oct 31, 2022
-
ragelib: use the correct visibility_of API
Signed-off-by: Edwin Török <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0725897 - Browse repository at this point
Copy the full SHA 0725897View commit details
Commits on Nov 9, 2022
-
Package library in a standard way
To prepare the library to work normally with pip install we: - define ragelib as a regular python package - move to setup.py and requirements.txt to pyproject.toml and setup.cfg We remove Pipfile because it's only useful for locking library versions, only that should only be done on non-library packages as these may cause conflicts otherwise. If there are any bounds these can be define in the dependencies Signed-off-by: Pau Ruiz Safont <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 72b41e9 - Browse repository at this point
Copy the full SHA 72b41e9View commit details
Commits on Feb 21, 2024
-
Fix race condition on alert presence
`expected.alert_is_present()` is always true, because it is a Selenium predicate (a `Callable` that expects a web-driver). This currently raises a NoSuchAlertException. We have to actually call the expectation with a driver, which will check if an alert is present, or return false (it internally catches this exception), instead of calling switch_to ourselves. Fixes: 69db96c ("Reorder element checking as to avoid 10s wait for dialogue pop-up") Signed-off-by: Edwin Török <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0a841cd - Browse repository at this point
Copy the full SHA 0a841cdView commit details -
Selenium has broken backwards compatibility with 3.9.0: * executable_path is no longer valid, now a service parameter needs to be used * firefox_options got renamed to option Add an upper bound on major version to avoid the library breaking again. Signed-off-by: Edwin Török <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e5a31a3 - Browse repository at this point
Copy the full SHA e5a31a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1874f80 - Browse repository at this point
Copy the full SHA 1874f80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13dec0f - Browse repository at this point
Copy the full SHA 13dec0fView commit details -
Merge pull request #4 from psafont/package-peping
Package library in a standard way
Configuration menu - View commit details
-
Copy full SHA for 7b8df64 - Browse repository at this point
Copy the full SHA 7b8df64View commit details
Commits on Feb 23, 2024
-
Merge pull request #5 from edwintorok/private/edvint/race
Fix race condition on alert presence
Configuration menu - View commit details
-
Copy full SHA for 8a5bb1b - Browse repository at this point
Copy the full SHA 8a5bb1bView commit details -
Merge pull request #6 from edwintorok/private/edvint/debian12
Update to Debian12 and Python3.11.2 requirements
Configuration menu - View commit details
-
Copy full SHA for 1c67c04 - Browse repository at this point
Copy the full SHA 1c67c04View commit details
Commits on Mar 4, 2024
-
CA-389464: avoid race condition with page load
There is some race condition between page loads and fetching the images: force new instance. Even though the code waits for certain page elements to appear and be in the correct state, apparently this only works on the first page. When loading the next page these elements will already be there and the page will be considered already loaded even though it hasn't fully finished loading yet. This is a "big hammer" approach, followup commits will use tabs instead of an entire new process. The effect of the race condition is that you see graphs from completely unrelated measurements shown in place of other graphs (which is a distinct bug from the "duplicate title causing overwrite" bug) Signed-off-by: Edwin Török <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a39c036 - Browse repository at this point
Copy the full SHA a39c036View commit details -
CA-389464: use tabs instead of completely new process
Switch to a new tab for each test, and then close it and switch back to the empty page. This ensures that every image fetch correctly waits for the entire page load, but without the overhead of spawning an entirely new browser process every time. Signed-off-by: Edwin Török <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c974bdf - Browse repository at this point
Copy the full SHA c974bdfView commit details -
Avoid leaving browser processes behind on errors Signed-off-by: Edwin Török <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 79a69c7 - Browse repository at this point
Copy the full SHA 79a69c7View commit details
Commits on Mar 8, 2024
-
Merge pull request #7 from edwintorok/private/edvint/imagerace
Fix race condition when fetching images
Configuration menu - View commit details
-
Copy full SHA for a4baf6b - Browse repository at this point
Copy the full SHA a4baf6bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master