Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mcintyre94/ragelib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: perf101/ragelib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 14 files changed
  • 8 contributors

Commits on Mar 25, 2018

  1. Improve timeout handling

    - Change timeout to 60s (5 mins is too long)
    - Catch exceptions when fetching the image and skip (better to get all
    images except 1 than crash)
    
    Signed-off-by: Callum McIntyre <[email protected]>
    Callum McIntyre authored and mcintyre94 committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    efa41ce View commit details
    Browse the repository at this point in the history
  2. Update URLs for perf101

    mcintyre94 committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    b97d492 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2018

  1. Merge pull request #2 from perf101/add-context

    Add the context to data
    mcintyre94 authored May 9, 2018
    Configuration menu
    Copy the full SHA
    e8c7dd0 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Add the context to data

    Context includes useful data about how the test ran - the soms, machines
    used, VMs used, and other test parameters. This is useful for
    differentiating between tests with the same/similar names, and without
    it we need to click through to the RAGE graph to determine how tests
    differed. ragelib now passes context of each row for consumers to use
    however suits them bet.
    
    Signed-off-by: Callum McIntyre <[email protected]>
    Callum McIntyre authored and YanRachel committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5f0bf11 View commit details
    Browse the repository at this point in the history
  2. Added handling of alert box popup when rage tries to graph with a lar…

    …ge number of points
    Patrick Cooke authored and YanRachel committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    1f9d621 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Configuration menu
    Copy the full SHA
    69db96c View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Merge pull request #3 from PCookies/private/patrickcoo/CP-38420

    Private/patrickcoo/cp 38420
    edwintorok authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    3512ac9 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. ragelib: use the correct visibility_of API

    Signed-off-by: Edwin Török <[email protected]>
    edwintorok committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    0725897 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Package library in a standard way

    To prepare the library to work normally with pip install we:
    - define ragelib as a regular python package
    - move to setup.py and requirements.txt to pyproject.toml and setup.cfg
    
    We remove Pipfile because it's only useful for locking library versions,
    only that should only be done on non-library packages as these may cause
    conflicts otherwise. If there are any bounds these can be define in the
    dependencies
    
    Signed-off-by: Pau Ruiz Safont <[email protected]>
    psafont committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    72b41e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Fix race condition on alert presence

    `expected.alert_is_present()` is always true, because it is a Selenium predicate
    (a `Callable` that expects a web-driver).
    
    This currently raises a NoSuchAlertException.
    We have to actually call the expectation with a driver, which will check if an alert is present,
    or return false (it internally catches this exception), instead of calling switch_to ourselves.
    
    Fixes: 69db96c ("Reorder element checking as to avoid 10s wait for dialogue pop-up")
    
    Signed-off-by: Edwin Török <[email protected]>
    edwintorok committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    0a841cd View commit details
    Browse the repository at this point in the history
  2. Update to Selenium 4.18.1

    Selenium has broken backwards compatibility with 3.9.0:
    * executable_path is no longer valid, now a service parameter needs to be used
    * firefox_options got renamed to option
    
    Add an upper bound on major version to avoid the library breaking again.
    
    Signed-off-by: Edwin Török <[email protected]>
    edwintorok committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e5a31a3 View commit details
    Browse the repository at this point in the history
  3. setup.cfg: fix typo

    edwintorok committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    1874f80 View commit details
    Browse the repository at this point in the history
  4. Delete __pycache__

    Signed-off-by: Edwin Török <[email protected]>
    edwintorok committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    13dec0f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #4 from psafont/package-peping

    Package library in a standard way
    edwintorok authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7b8df64 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge pull request #5 from edwintorok/private/edvint/race

    Fix race condition on alert presence
    edwintorok authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8a5bb1b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #6 from edwintorok/private/edvint/debian12

    Update to Debian12 and Python3.11.2 requirements
    edwintorok authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1c67c04 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. CA-389464: avoid race condition with page load

    There is some race condition between page loads and fetching the images: force new instance.
    Even though the code waits for certain page elements to appear and be in the correct state, apparently this only works on the first page.
    When loading the next page these elements will already be there and the page will be considered already loaded even though it hasn't fully finished loading yet.
    
    This is a "big hammer" approach, followup commits will use tabs instead of an entire new process.
    
    The effect of the race condition is that you see graphs from completely unrelated measurements shown in place of other graphs
    (which is a distinct bug from the "duplicate title causing overwrite" bug)
    
    Signed-off-by: Edwin Török <[email protected]>
    edwintorok committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a39c036 View commit details
    Browse the repository at this point in the history
  2. CA-389464: use tabs instead of completely new process

    Switch to a new tab for each test, and then close it and switch back to the empty page.
    This ensures that every image fetch correctly waits for the entire page load, but without the overhead of spawning an entirely new browser process every time.
    
    Signed-off-by: Edwin Török <[email protected]>
    edwintorok committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c974bdf View commit details
    Browse the repository at this point in the history
  3. driver: use context manager

    Avoid leaving browser processes behind on errors
    
    Signed-off-by: Edwin Török <[email protected]>
    edwintorok committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    79a69c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge pull request #7 from edwintorok/private/edvint/imagerace

    Fix race condition when fetching images
    edwintorok authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a4baf6b View commit details
    Browse the repository at this point in the history
Loading