#15: wolf_sheep readme update & dockerization #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdated main README.rst with instructions
rht
reviewed
Jan 5, 2023
| # If you want to make it run in the background, you instead run | ||
| $ docker compose up -d | ||
| This runs the wolf-sheep predation model by default. If you wish to run another example, simply update the MODEL_DIR variable both in the Dockerfile and docker-compose.yml files. |
Contributor
There was a problem hiding this comment.
Is this true? Updating the one in docker-compose.yml should override the Dockerfile value.
Contributor
|
Thank you for the PR. Other than that one comment, the PR content LGTM (ideally, the gitignore change should be in its own commit, but it's fine no worries). Though, the commit messages are too long, and they should be an imperative statement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed the instructions for wolf_sheep were out of date due to the repo change. I opened ticket #15 (but could not assign myself, sorry) and made this PR.
In addition to updating the readme, I also migrated the dockerization from the main repository, I confirmed it worked with a few different models and updated the main readme.
Happy to make any changes requested.
Thanks!