Fix eat function in Sugrascpae_g1mt #19
Conversation
- Include interactive version with single run, batch run and server options - Update .gitignore to ignore IDE environment files
…orer Tutorial - update Readme so batch run does not get an arugment error - update run so data processing of batchrunner doe snot get a key error
| sugar_patch = self.get_sugar(self.pos) | ||
| # eat sugar | ||
|
|
||
| if sugar_patch: |
There was a problem hiding this comment.
Shouldn't this be:
if sugar_patch:
self.sugar += sugar_patch.amount
sugar_patch.amount = 0
self.sugar -= metabolism_sugar?
There was a problem hiding this comment.
I interpreted the matrix conversation that you didn't have a strong opinion either-- the way I changed it or the way you commented.
With how I changed it is just adding lines, although more verbose, vs rewriting the if statement
What do you think?
There was a problem hiding this comment.
I do think simplifying to not have else does definitely clarify the code that self.sugar -= metabolism_sugar happens in all branches of execution. The one that I don't have opinion is on the grouping collect sugar, eat sugar, collect spice, eat spice vs collect sugar & spice, eat sugar & spice.
There was a problem hiding this comment.
Ahhh...got it I will update and sync the tutorial as well.
|
Sorry not sure why my last branch didn't just update this pull request. I am closing this one |
2 participants
This fixes the complexity explorer user identified error as well as two other bugs found in running the example (processing batch run and running batch run)