Skip to content

Refactor SpaceRenderer API to separate setup and draw methods #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sahil-Chhoker wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Refactor SpaceRenderer API to separate setup and draw methods #2893

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a53d8e8
separate setup functions from drawing functions
Sahil-Chhoker Nov 18, 2025
e39df00
simplify axes clearing
Sahil-Chhoker Nov 18, 2025
3f410d0
cleanup
Sahil-Chhoker Nov 18, 2025
238f33c
Revert "simplify axes clearing"
Sahil-Chhoker Nov 18, 2025
f23d486
cleanup-2
Sahil-Chhoker Nov 18, 2025
f88aff5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 20, 2025
09fe545
fix chart_props in network draw altair
Sahil-Chhoker Nov 20, 2025
edb3251
remove older method calls from canvas
Sahil-Chhoker Nov 20, 2025
077dee2
ensure backwards compatability
Sahil-Chhoker Nov 22, 2025
b8acbb5
update tests
Sahil-Chhoker Nov 22, 2025
def6a45
update virus_on_network
Sahil-Chhoker Nov 22, 2025
de29623
update schelling example
Sahil-Chhoker Nov 22, 2025
2faa078
update game_of_life example
Sahil-Chhoker Nov 22, 2025
70d447e
update boltzman_wealth_model example
Sahil-Chhoker Nov 22, 2025
7ba7a91
update bold_flockers example
Sahil-Chhoker Nov 22, 2025
953f0ca
cleanup and update wolf-sheep example
Sahil-Chhoker Nov 22, 2025
b23868c
update sugarscape example
Sahil-Chhoker Nov 22, 2025
b903326
update pd_grid example
Sahil-Chhoker Nov 22, 2025
7ae4afc
update civil_voilence example
Sahil-Chhoker Nov 22, 2025
8a22250
update tests inline with the new-API
Sahil-Chhoker Nov 22, 2025
d663821
Merge branch 'main' into viz-api-update
Sahil-Chhoker Nov 22, 2025
54e32df
nitpick improvements
Sahil-Chhoker Nov 22, 2025
d63ca10
change deprecation to pending deprecation warnings
Sahil-Chhoker Nov 25, 2025
d88b41b
Merge branch 'main' into viz-api-update
Sahil-Chhoker Nov 25, 2025
c2e6032
empty commit
Sahil-Chhoker Nov 25, 2025
a48c3d5
Merge branch 'viz-api-update' of https://github.com/Sahil-Chhoker/mes…
Sahil-Chhoker Nov 25, 2025
9d59fca
Merge branch 'main' into viz-api-update
tpike3 Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update tests
  • Loading branch information
@Sahil-Chhoker
Sahil-Chhoker committed Nov 22, 2025
commit b8acbb51d926387bce0e9f754064bea0fa6e9916
6 changes: 3 additions & 3 deletions tests/test_solara_viz_updated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def agent_portrayal(agent):
)

mock_draw_space.assert_called_with(renderer)
mock_draw_agents.assert_called_with(renderer, agent_portrayal)
mock_draw_agents.assert_called_with(renderer)
# should not call this method if portrayal is None
mock_draw_properties.assert_not_called()

Expand Down Expand Up @@ -201,8 +201,8 @@ def agent_portrayal(agent):
)

mock_draw_space.assert_called_with(renderer)
mock_draw_agents.assert_called_with(renderer, agent_portrayal)
mock_draw_properties.assert_called_with(renderer, propertylayer_portrayal)
mock_draw_agents.assert_called_with(renderer)
mock_draw_properties.assert_called_with(renderer)

mock_draw_space.reset_mock()
mock_draw_agents.reset_mock()
Expand Down