Skip to content

Commit b1322c4

Browse files
fix wsl links (#5251)
* fix wsl links * forgot to save file * ai 3d fix --------- Co-authored-by: Alec Bills <[email protected]>
1 parent 195b639 commit b1322c4

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

docs/source/user_guide/installation/install-from-source.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Prerequisites
1616
---------------
1717

1818
The following instructions are valid for both GNU/Linux distributions and MacOS.
19-
If you are running Windows, consider using the `Windows Subsystem for Linux (WSL) <https://docs.microsoft.com/en-us/windows/wsl/install-win10>`_.
19+
If you are running Windows, consider using the `Windows Subsystem for Linux (WSL) <https://learn.microsoft.com/en-us/windows/wsl/install-win10>`_.
2020

2121
To obtain the PyBaMM source code, clone the GitHub repository
2222

docs/source/user_guide/installation/windows-wsl.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ To make it easier to install PyBaMM, we recommend using the Windows Subsystem fo
66
Install WSL
77
-----------
88

9-
Install Ubuntu 22.04 or 20.04 LTS as a distribution for WSL following `Microsoft's guide to install WSL <https://docs.microsoft.com/en-us/windows/wsl/install-win10>`__. For a seamless development environment, refer to `this guide <https://docs.microsoft.com/en-us/windows/wsl/setup/environment>`__.
9+
Install Ubuntu 22.04 or 20.04 LTS as a distribution for WSL following `Microsoft's guide to install WSL <https://learn.microsoft.com/en-us/windows/wsl/install-win10>`__.
1010

1111
Install PyBaMM
1212
--------------

src/pybamm/models/full_battery_models/lithium_ion/basic_spm_with_3d_thermal.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,14 @@ def set_thermal_bcs(self, T):
287287
) # pragma: no cover
288288

289289
self.boundary_conditions[T] = {}
290-
lambda_eff = self.param.lambda_eff(T)
291290

292291
for face, h_coeff in face_params.items():
293-
q_face = -h_coeff * (T - T_amb)
294-
self.boundary_conditions[T][face] = (q_face / lambda_eff, "Neumann")
292+
# Evaluate T and lambda_eff at the boundary
293+
T_boundary = pybamm.boundary_value(T, face)
294+
lambda_eff_boundary = pybamm.boundary_value(self.param.lambda_eff(T), face)
295+
# T_amb is already evaluated at the boundary coordinates
296+
q_face = -h_coeff * (T_boundary - T_amb)
297+
self.boundary_conditions[T][face] = (
298+
q_face / lambda_eff_boundary,
299+
"Neumann",
300+
)

0 commit comments

Comments
 (0)