CA-183752: Block VDI forget/destroy operation for rrd stats VDI

Signed-off-by: Sharad Yadav <[email protected]>

Author: sharady

ocaml/idl/api_errors.ml

@@ -216,6 +216,7 @@ let vbd_cds_must_be_readonly = "VBD_CDS_MUST_BE_READONLY"
 let disk_vbd_must_be_readwrite_for_hvm = "DISK_VBD_MUST_BE_READWRITE_FOR_HVM"
 let host_cd_drive_empty = "HOST_CD_DRIVE_EMPTY"
 let vdi_not_available = "VDI_NOT_AVAILABLE"
+let vdi_has_rrds = "VDI_HAS_RRDS"
 let vdi_location_missing = "VDI_LOCATION_MISSING"
 let vdi_content_id_missing = "VDI_CONTENT_ID_MISSING"
 let vdi_missing = "VDI_MISSING"

ocaml/idl/datamodel.ml

@@ -966,6 +966,8 @@ let _ =
     ~doc:"The operation could not proceed because necessary VDIs were already locked at the storage level." ();
   error Api_errors.vdi_readonly [ "vdi" ]
     ~doc:"The operation required write access but this VDI is read-only" ();
+  error Api_errors.vdi_has_rrds [ "vdi" ]
+    ~doc:"The operation cannot be performed because this VDI has rrd stats" ();
   error Api_errors.vdi_too_small [ "vdi"; "minimum size" ]
     ~doc:"The VDI is too small. Please resize it to at least the minimum size." ();
   error Api_errors.vdi_not_sparse [ "vdi" ]

ocaml/xapi/xapi_vdi.ml

@@ -128,13 +128,17 @@ let check_operation_error ~__context ?(sr_records=[]) ?(pbd_records=[]) ?(vbd_re
 				| `forget ->
 					if ha_enabled && List.mem record.Db_actions.vDI_type [ `ha_statefile; `redo_log ]
 					then Some (Api_errors.ha_is_enabled, [])
+					else if List.mem record.Db_actions.vDI_type [ `rrd ]
+					then Some (Api_errors.vdi_has_rrds, [_ref])
 					else None
 				| `destroy ->
 					if sr_type = "udev"
 					then Some (Api_errors.vdi_is_a_physical_device, [_ref])
 					else
 						if is_tools_sr
 						then Some (Api_errors.sr_operation_not_supported, [Ref.string_of sr])
+						else if List.mem record.Db_actions.vDI_type [ `rrd ]
+						then Some (Api_errors.vdi_has_rrds, [_ref])
 						else
 							if ha_enabled && List.mem record.Db_actions.vDI_type [ `ha_statefile; `redo_log ]
 							then Some (Api_errors.ha_is_enabled, [])