Skip to content

Commit 5af652f

Browse files
committed
Merge pull request #54 from scribble/rhu1/rhu1-pr-tidying
Rhu1/rhu1 pr tidying
2 parents 3a2ad5c + fbbb483 commit 5af652f

32 files changed

Lines changed: 72 additions & 72 deletions

modules/cli/src/main/java/org/scribble/main/MainContext.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
import org.scribble.main.resource.Resource;
1414
import org.scribble.main.resource.ResourceLocator;
1515
import org.scribble.parser.AntlrParser;
16-
import org.scribble.parser.ScribbleModuleLoader;
17-
import org.scribble.parser.ScribbleParser;
16+
import org.scribble.parser.ScribModuleLoader;
17+
import org.scribble.parser.ScribParser;
1818
import org.scribble.sesstype.name.ModuleName;
1919
import org.scribble.util.Pair;
2020

@@ -31,10 +31,10 @@ public class MainContext
3131

3232
// Only "manually" used here for loading main module (which should be factored out to front end) -- otherwise, only used within loader
3333
private final AntlrParser antlrParser; // Not encapsulated inside ScribbleParser, because ScribbleParser's main function is to "parse" ANTLR CommonTrees into ModelNodes
34-
private final ScribbleParser scribParser;
34+
private final ScribParser scribParser;
3535

3636
private final ResourceLocator locator; // Path -> Resource
37-
private final ScribbleModuleLoader loader; // sesstype.ModuleName -> Pair<Resource, Module>
37+
private final ScribModuleLoader loader; // sesstype.ModuleName -> Pair<Resource, Module>
3838

3939
// ModuleName keys are full module names -- parsed are the modules read from file, distinguished from the generated projection modules
4040
// Resource recorded for source path
@@ -45,9 +45,9 @@ public MainContext(boolean debug, ResourceLocator locator, Path mainpath)
4545
{
4646
this.debug = debug;
4747
this.antlrParser = new AntlrParser();
48-
this.scribParser = new ScribbleParser();
48+
this.scribParser = new ScribParser();
4949
this.locator = locator;
50-
this.loader = new ScribbleModuleLoader(this.locator, this.antlrParser, this.scribParser);
50+
this.loader = new ScribModuleLoader(this.locator, this.antlrParser, this.scribParser);
5151

5252
Pair<Resource, Module> p = loadMainModule(mainpath);
5353
this.main = p.right.getFullModuleName();

modules/parser/src/main/antlr3/org/scribble/parser/antlr/Scribble2.g renamed to modules/parser/src/main/antlr3/org/scribble/parser/antlr/Scribble.g

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*/
44

55

6-
grammar Scribble2;
6+
grammar Scribble;
77

88

99
options

modules/parser/src/main/java/org/scribble/parser/AntlrParser.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
import org.antlr.runtime.RecognitionException;
99
import org.antlr.runtime.tree.CommonTree;
1010
import org.scribble.main.resource.Resource;
11-
import org.scribble.parser.antlr.Scribble2Lexer;
12-
import org.scribble.parser.antlr.Scribble2Parser;
11+
import org.scribble.parser.antlr.ScribbleLexer;
12+
import org.scribble.parser.antlr.ScribbleParser;
1313

1414
// Resource -> ANTLR CommonTree
1515
// Parses Resources into ANTLR CommonTrees
@@ -26,8 +26,8 @@ public CommonTree parseAntlrTree(Resource res)
2626
try
2727
{
2828
String input = new String(readResource(res));
29-
Scribble2Lexer lex = new Scribble2Lexer(new ANTLRStringStream(input));
30-
Scribble2Parser parser = new Scribble2Parser(new CommonTokenStream(lex));
29+
ScribbleLexer lex = new ScribbleLexer(new ANTLRStringStream(input));
30+
ScribbleParser parser = new ScribbleParser(new CommonTokenStream(lex));
3131
return (CommonTree) parser.module().getTree();
3232
}
3333
catch (RecognitionException e)

modules/parser/src/main/java/org/scribble/parser/ScribbleModuleLoader.java renamed to modules/parser/src/main/java/org/scribble/parser/ScribModuleLoader.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@
2626
// loading = ModuleName -> Module
2727
// ModuleName --> Path --ResourceLocator--> Resource --AntlrParser--> ANTLR --ScribParser--> ScribNode
2828
// FIXME: should be in core org.scribble.main -- here due to Maven dependency restrictions
29-
public class ScribbleModuleLoader extends DefaultModuleLoader //implements ModuleLoader
29+
public class ScribModuleLoader extends DefaultModuleLoader //implements ModuleLoader
3030
{
3131
private ResourceLocator locator;
3232
private AntlrParser antlr;
33-
private ScribbleParser parser;
33+
private ScribParser parser;
3434

35-
public ScribbleModuleLoader(ResourceLocator locator, AntlrParser antlr, ScribbleParser parser)
35+
public ScribModuleLoader(ResourceLocator locator, AntlrParser antlr, ScribParser parser)
3636
{
3737
this.locator = locator;
3838
this.antlr = antlr;

modules/parser/src/main/java/org/scribble/parser/ScribbleParser.java renamed to modules/parser/src/main/java/org/scribble/parser/ScribParser.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@
3838

3939
// ANTLR CommonTree -> ScribNode
4040
// Parses ANTLR nodes into ScribNodes using the parser.ast.Antlr[...] helper classes
41-
public class ScribbleParser
41+
public class ScribParser
4242
{
43-
public ScribbleParser()
43+
public ScribParser()
4444
{
4545

4646
}

modules/parser/src/main/java/org/scribble/parser/ast/AntlrDataTypeDecl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import org.scribble.ast.DataTypeDecl;
55
import org.scribble.ast.AstFactoryImpl;
66
import org.scribble.ast.name.qualified.DataTypeNameNode;
7-
import org.scribble.parser.ScribbleParser;
7+
import org.scribble.parser.ScribParser;
88
import org.scribble.parser.ast.name.AntlrSimpleName;
99

1010
public class AntlrDataTypeDecl
@@ -14,7 +14,7 @@ public class AntlrDataTypeDecl
1414
public static final int SOURCE_CHILD_INDEX = 2;
1515
public static final int ALIAS_CHILD_INDEX = 3;
1616

17-
public static DataTypeDecl parseDataTypeDecl(ScribbleParser parser, CommonTree ct)
17+
public static DataTypeDecl parseDataTypeDecl(ScribParser parser, CommonTree ct)
1818
{
1919
CommonTree tmp1 = getSchemaChild(ct);
2020
String schema = AntlrSimpleName.getName(tmp1);

modules/parser/src/main/java/org/scribble/parser/ast/AntlrImportModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import org.scribble.ast.ImportModule;
55
import org.scribble.ast.AstFactoryImpl;
66
import org.scribble.ast.name.qualified.ModuleNameNode;
7-
import org.scribble.parser.ScribbleParser;
7+
import org.scribble.parser.ScribParser;
88
import org.scribble.parser.ast.name.AntlrQualifiedName;
99

1010
public class AntlrImportModule
@@ -14,7 +14,7 @@ public class AntlrImportModule
1414

1515
private static final String EMPTY_ALIAS = "EMPTY_ALIAS";
1616

17-
public static ImportModule parseImportModule(ScribbleParser parser, CommonTree ct)
17+
public static ImportModule parseImportModule(ScribParser parser, CommonTree ct)
1818
{
1919
ModuleNameNode fmn = AntlrQualifiedName.toModuleNameNode(getModuleNameChild(ct));
2020
ModuleNameNode alias =

modules/parser/src/main/java/org/scribble/parser/ast/AntlrMessageSig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
import org.scribble.ast.AstFactoryImpl;
66
import org.scribble.ast.PayloadElemList;
77
import org.scribble.ast.name.simple.OpNode;
8-
import org.scribble.parser.ScribbleParser;
8+
import org.scribble.parser.ScribParser;
99
import org.scribble.parser.ast.name.AntlrSimpleName;
1010

1111
public class AntlrMessageSig
1212
{
1313
public static final int OPERATOR_CHILD_INDEX = 0;
1414
public static final int PAYLOAD_CHILD_INDEX = 1;
1515

16-
public static MessageSigNode parseMessageSig(ScribbleParser parser, CommonTree ct)
16+
public static MessageSigNode parseMessageSig(ScribParser parser, CommonTree ct)
1717
{
1818
OpNode op = AntlrSimpleName.toOpNode(getOpChild(ct));
1919
PayloadElemList payload = (PayloadElemList) parser.parse(getPayloadElemListChild(ct));

modules/parser/src/main/java/org/scribble/parser/ast/AntlrMessageSigDecl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import org.scribble.ast.MessageSigNameDecl;
55
import org.scribble.ast.AstFactoryImpl;
66
import org.scribble.ast.name.qualified.MessageSigNameNode;
7-
import org.scribble.parser.ScribbleParser;
7+
import org.scribble.parser.ScribParser;
88
import org.scribble.parser.ast.name.AntlrSimpleName;
99

1010
// FIXME: factor out with AntlrDataTypeDecl
@@ -15,7 +15,7 @@ public class AntlrMessageSigDecl
1515
public static final int SOURCE_CHILD_INDEX = 2;
1616
public static final int ALIAS_CHILD_INDEX = 3;
1717

18-
public static MessageSigNameDecl parseMessageSigDecl(ScribbleParser parser, CommonTree ct)
18+
public static MessageSigNameDecl parseMessageSigDecl(ScribParser parser, CommonTree ct)
1919
{
2020
CommonTree tmp1 = getSchemaChild(ct);
2121
String schema = AntlrSimpleName.getName(tmp1);

modules/parser/src/main/java/org/scribble/parser/ast/AntlrModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
import org.scribble.ast.NonProtocolDecl;
1414
import org.scribble.ast.ProtocolDecl;
1515
import org.scribble.parser.AntlrConstants.AntlrNodeType;
16-
import org.scribble.parser.ScribbleParser;
16+
import org.scribble.parser.ScribParser;
1717
import org.scribble.parser.util.ScribParserUtil;
1818

1919
public class AntlrModule
2020
{
2121
public static final int MODULEDECL_CHILD_INDEX = 0;
2222

23-
public static Module parseModule(ScribbleParser parser, CommonTree ct)
23+
public static Module parseModule(ScribParser parser, CommonTree ct)
2424
{
2525
ModuleDecl md = (ModuleDecl) parser.parse(getModuleDeclChild(ct));
2626
List<ImportDecl<?>> ids = new LinkedList<>();

0 commit comments

Comments
 (0)