Doc tutorial #14
Merged
Doc tutorial #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aporan
previously approved these changes
Jan 21, 2018
Collaborator
There was a problem hiding this comment.
It works perfectly fine.
I did have trouble setting up environment paths though. I had to make this modification in the makefile cause sudo was not detecting minicps in PYTHONPATH.
PYTHON = sudo PYTHONPATH="${PYTHONPATH}" python.
Perhaps, we should mention ensure proper path is set up somewhere just for ease of use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@remmihsorp
I've added some extra instructions for the tutorial doc because it was missing the steps required to init
the simulation (eg: init the database).
Could you please test if
make swat-initworks and the relevant doc make sense?Thanks!