Support for multitag requests on ENIP #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noleti
previously approved these changes
May 8, 2023
Collaborator
noleti
left a comment
noleti
left a comment
There was a problem hiding this comment.
Looks good to me, overall few additions, minor cleanup of prior stuff
…sion of CPPPO. This also solves the issue with the warning messages if CPPPO=4.3.4 is used
Collaborator
|
Thanks @afmurillo, but it looks like you added some debug |
…sion of CPPPO. This also solves the issue with the warning messages if CPPPO=4.3.4 is used
Contributor
Author
|
Hello, @noleti I have commented the print() status. The --print present in lines 472 and 513 was the result of the debug session we had a couple of weeks ago. Those --print allow DHALSIM PLCs to receive tags values using ENIP. |
noleti
approved these changes
Jun 8, 2023
Collaborator
noleti
left a comment
noleti
left a comment
There was a problem hiding this comment.
all good per shared discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two functions are added to devices.py and protocols.py to support sending and receiving multiple tags using ENIP.