Skip to content

Commit ca98acf

Browse files
stuartrowejglick
andauthored
Apply suggestions from code review
Make the RunWrapperTest#externalizableId) test more robust and exercise the property getter. Co-authored-by: Jesse Glick <[email protected]>
1 parent 3ded1d4 commit ca98acf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/test/java/org/jenkinsci/plugins/workflow/support/steps/build/RunWrapperTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,9 +292,9 @@ public void upstreamBuilds() throws Throwable {
292292
public void externalizableId() throws Throwable {
293293
sessions.then(j -> {
294294
WorkflowJob first = j.createProject(WorkflowJob.class, "first-job");
295-
first.setDefinition(new CpsFlowDefinition("echo currentBuild.getExternalizableId()\n", true));
295+
first.setDefinition(new CpsFlowDefinition("echo(/externalizableId=$currentBuild.externalizableId/)", true));
296296
WorkflowRun firstRun = j.buildAndAssertSuccess(first);
297-
j.assertLogContains(firstRun.getExternalizableId(), firstRun);
297+
j.assertLogContains("externalizableId=first-job#1", firstRun);
298298
});
299299
}
300300

0 commit comments

Comments
 (0)