turning down logging on classcast miss

Greg Whalin · Greg Whalin · commit 49455629ccc7 · 2009-06-05T11:38:47.000-04:00
diff --git a/src/com/meetup/memcached/MemcachedClient.java b/src/com/meetup/memcached/MemcachedClient.java
@@ -1338,8 +1338,7 @@ public Object get( String key, Integer hashCode, boolean asString ) {
 							if ( errorHandler != null )
 								errorHandler.handleErrorOnGet( this, e, key );
 
-							log.error( "++++ IOException thrown while trying to uncompress input stream for key: " + key );
-							log.error( e.getMessage(), e );
+							log.error( "++++ IOException thrown while trying to uncompress input stream for key: " + key + " -- " + e.getMessage() );
 							throw new NestedIOException( "++++ IOException thrown while trying to uncompress input stream for key: " + key, e );
 						}
 					}
@@ -1383,7 +1382,7 @@ public Object get( String key, Integer hashCode, boolean asString ) {
 							if ( errorHandler != null )
 								errorHandler.handleErrorOnGet( this, e, key );
 
-							log.error( "++++ ClassNotFoundException thrown while trying to deserialize for key: " + key, e );
+							log.error( "++++ ClassNotFoundException thrown while trying to deserialize for key: " + key + " -- " + e.getMessage() );
 							throw new NestedIOException( "+++ failed while trying to deserialize for key: " + key, e );
 						}
 					}
@@ -1406,8 +1405,7 @@ else if ( END.equals( line ) ) {
 				errorHandler.handleErrorOnGet( this, e, key );
 
 			// exception thrown
-			log.error( "++++ exception thrown while trying to get object from cache for key: " + key );
-			log.error( e.getMessage(), e );
+			log.error( "++++ exception thrown while trying to get object from cache for key: " + key + " -- " + e.getMessage() );
 
 			try {
 				sock.trueClose();
@@ -1681,8 +1679,7 @@ private void loadMulti( LineInputStream input, Map<String,Object> hm, boolean as
 						if ( errorHandler != null )
 							errorHandler.handleErrorOnGet( this, e, key );
 
-						log.error( "++++ IOException thrown while trying to uncompress input stream for key: " + key );
-						log.error( e.getMessage(), e );
+						log.error( "++++ IOException thrown while trying to uncompress input stream for key: " + key + " -- " + e.getMessage() );
 						throw new NestedIOException( "++++ IOException thrown while trying to uncompress input stream for key: " + key, e );
 					}
 				}
@@ -1706,7 +1703,7 @@ private void loadMulti( LineInputStream input, Map<String,Object> hm, boolean as
 							if ( errorHandler != null )
 								errorHandler.handleErrorOnGet( this, e, key );
 
-							log.error( "++++ Exception thrown while trying to deserialize for key: " + key, e );
+							log.error( "++++ Exception thrown while trying to deserialize for key: " + key + " -- " + e.getMessage() );
 							throw new NestedIOException( e );
 						}
 					}
@@ -1726,7 +1723,7 @@ private void loadMulti( LineInputStream input, Map<String,Object> hm, boolean as
 						if ( errorHandler != null )
 							errorHandler.handleErrorOnGet( this, e, key );
 
-						log.error( "++++ ClassNotFoundException thrown while trying to deserialize for key: " + key, e );
+						log.error( "++++ ClassNotFoundException thrown while trying to deserialize for key: " + key + " -- " + e.getMessage() );
 						throw new NestedIOException( "+++ failed while trying to deserialize for key: " + key, e );
 					}
 				}

Original file line number	Diff line number	Diff line change
`@@ -1338,8 +1338,7 @@ public Object get( String key, Integer hashCode, boolean asString ) {`
`1338`	`1338`	`if ( errorHandler != null )`
`1339`	`1339`	`errorHandler.handleErrorOnGet( this, e, key );`
`1340`	`1340`
`1341`		`- log.error( "++++ IOException thrown while trying to uncompress input stream for key: " + key );`
`1342`		`- log.error( e.getMessage(), e );`
	`1341`	`+ log.error( "++++ IOException thrown while trying to uncompress input stream for key: " + key + " -- " + e.getMessage() );`
`1343`	`1342`	`throw new NestedIOException( "++++ IOException thrown while trying to uncompress input stream for key: " + key, e );`
`1344`	`1343`	`}`
`1345`	`1344`	`}`
`@@ -1383,7 +1382,7 @@ public Object get( String key, Integer hashCode, boolean asString ) {`
`1383`	`1382`	`if ( errorHandler != null )`
`1384`	`1383`	`errorHandler.handleErrorOnGet( this, e, key );`
`1385`	`1384`
`1386`		`- log.error( "++++ ClassNotFoundException thrown while trying to deserialize for key: " + key, e );`
	`1385`	`+ log.error( "++++ ClassNotFoundException thrown while trying to deserialize for key: " + key + " -- " + e.getMessage() );`
`1387`	`1386`	`throw new NestedIOException( "+++ failed while trying to deserialize for key: " + key, e );`
`1388`	`1387`	`}`
`1389`	`1388`	`}`
`@@ -1406,8 +1405,7 @@ else if ( END.equals( line ) ) {`
`1406`	`1405`	`errorHandler.handleErrorOnGet( this, e, key );`
`1407`	`1406`
`1408`	`1407`	`// exception thrown`
`1409`		`- log.error( "++++ exception thrown while trying to get object from cache for key: " + key );`
`1410`		`- log.error( e.getMessage(), e );`
	`1408`	`+ log.error( "++++ exception thrown while trying to get object from cache for key: " + key + " -- " + e.getMessage() );`
`1411`	`1409`
`1412`	`1410`	`try {`
`1413`	`1411`	`sock.trueClose();`
`@@ -1681,8 +1679,7 @@ private void loadMulti( LineInputStream input, Map<String,Object> hm, boolean as`
`1681`	`1679`	`if ( errorHandler != null )`
`1682`	`1680`	`errorHandler.handleErrorOnGet( this, e, key );`
`1683`	`1681`
`1684`		`- log.error( "++++ IOException thrown while trying to uncompress input stream for key: " + key );`
`1685`		`- log.error( e.getMessage(), e );`
	`1682`	`+ log.error( "++++ IOException thrown while trying to uncompress input stream for key: " + key + " -- " + e.getMessage() );`
`1686`	`1683`	`throw new NestedIOException( "++++ IOException thrown while trying to uncompress input stream for key: " + key, e );`
`1687`	`1684`	`}`
`1688`	`1685`	`}`
`@@ -1706,7 +1703,7 @@ private void loadMulti( LineInputStream input, Map<String,Object> hm, boolean as`
`1706`	`1703`	`if ( errorHandler != null )`
`1707`	`1704`	`errorHandler.handleErrorOnGet( this, e, key );`
`1708`	`1705`
`1709`		`- log.error( "++++ Exception thrown while trying to deserialize for key: " + key, e );`
	`1706`	`+ log.error( "++++ Exception thrown while trying to deserialize for key: " + key + " -- " + e.getMessage() );`
`1710`	`1707`	`throw new NestedIOException( e );`
`1711`	`1708`	`}`
`1712`	`1709`	`}`
`@@ -1726,7 +1723,7 @@ private void loadMulti( LineInputStream input, Map<String,Object> hm, boolean as`
`1726`	`1723`	`if ( errorHandler != null )`
`1727`	`1724`	`errorHandler.handleErrorOnGet( this, e, key );`
`1728`	`1725`
`1729`		`- log.error( "++++ ClassNotFoundException thrown while trying to deserialize for key: " + key, e );`
	`1726`	`+ log.error( "++++ ClassNotFoundException thrown while trying to deserialize for key: " + key + " -- " + e.getMessage() );`
`1730`	`1727`	`throw new NestedIOException( "+++ failed while trying to deserialize for key: " + key, e );`
`1731`	`1728`	`}`
`1732`	`1729`	`}`