Use matchers, maybe the asserts were getting misplaced?

Author: holdenk

src/test/scala/com/sparklingpandas/sparklingml/feature/LuceneAnalyzerGeneratorsTest.scala

@@ -19,15 +19,15 @@ package com.sparklingpandas.sparklingml.feature
 
 import sys.process._
 
-import org.scalatest.FunSuite
+import org.scalatest._
 
-class LuceneAnalyzerGeneratorsTest extends FunSuite {
+class LuceneAnalyzerGeneratorsTest extends FunSuite with Matchers{
   test("verify the generated code is up to date") {
     LuceneAnalyzerGenerators.main(Array[String]())
     val basePath = "scala/com/sparklingpandas/sparklingml/feature/"
     val testResult = s"git diff -q ./src/test/${basePath}LuceneAnalyzersTests.scala".!
     val transformResult = s"git diff -q ./src/main/${basePath}LuceneAnalyzers.scala".!
-    assert(testResult === 0)
-    assert(transformResult === 0)
+    testResult shouldBe 0
+    transformResult shouldBe 0
   }
 }

src/test/scala/com/sparklingpandas/sparklingml/feature/LuceneBaseTests.scala

@@ -21,7 +21,7 @@ import org.apache.spark.ml.param._
 
 import org.apache.lucene.analysis.Analyzer
 
-import org.scalatest.FunSuite
+import org.scalatest._
 
 import com.holdenkarau.spark.testing.DataFrameSuiteBase
 
@@ -30,7 +30,7 @@ import com.sparklingpandas.sparklingml.param._
 case class InputData(input: String)
 
 abstract class LuceneTransformerTest[T <: LuceneTransformer[_]] extends
-    FunSuite with DataFrameSuiteBase {
+    FunSuite with DataFrameSuiteBase with Matchers {
   val transformer: T
 
   test("verify that the transformer runs") {
@@ -39,7 +39,7 @@ abstract class LuceneTransformerTest[T <: LuceneTransformer[_]] extends
       List(InputData("hi"), InputData("boo"), InputData("boop")))
     transformer.setInputCol("input")
     val result = transformer.transform(input).collect()
-    assert(result.size === 3)
+    result.size shouldBe 3
   }
 }
 
@@ -54,7 +54,7 @@ abstract class LuceneStopwordTransformerTest[T <: LuceneTransformer[_]] extends
     thst.setStopwords(Array("boop"))
     transformer.asInstanceOf[T].setInputCol("input")
     val result = transformer.transform(input).collect()
-    assert(result.size === 3)
-    assert(result(2).getSeq(1).isEmpty)
+    result.size shouldBe 3
+    result(2).getSeq(1) shouldBe empty
   }
 }

src/test/scala/com/sparklingpandas/sparklingml/param/SharedParamsCodeGenTest.scala

@@ -19,13 +19,13 @@ package com.sparklingpandas.sparklingml.param
 
 import sys.process._
 
-import org.scalatest.FunSuite
+import org.scalatest._
 
-class SharedParamsCodeGenTest extends FunSuite {
+class SharedParamsCodeGenTest extends FunSuite with Matchers {
   test("verify the generated code is up to date") {
     SharedParamsCodeGen.main(Array[String]())
     val basePath = "scala/com/sparklingpandas/sparklingml/param/"
     val result = s"git diff -q ./src/main/${basePath}/sharedParams.scala".!
-    assert(result === 0)
+    result shouldBe 0
   }
 }